Rainbows! Rack HTTP server user/dev discussion
 help / Atom feed
From: Eric Wong <e@80x24.org>
To: rainbows-public@bogomips.org
Subject: [PATCH] speed up QUIT for users of the unicorn worker_loop
Date: Thu, 15 Oct 2015 01:37:33 +0000
Message-ID: <20151015013733.27968-1-e@80x24.org> (raw)

WriterThreadPool, WriterThreadSpawn, Base, and potentially
other rarely-used concurrency options experienced slow shutdowns
due to the destruction of a listener socket failing to wake up
a thread in IO.select.

Send ourselves a signal to interrupt the IO.select call in
the main thread to force the wakeup.
---
 lib/rainbows.rb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/rainbows.rb b/lib/rainbows.rb
index 3bebf34..0af5620 100644
--- a/lib/rainbows.rb
+++ b/lib/rainbows.rb
@@ -93,6 +93,9 @@ module Rainbows
       @readers.clear
       tmp.each { |s| s.close rescue nil }.clear
       @at_quit.each { |task| task.call }
+
+      # XXX hack to break out of IO.select in worker_loop for some models
+      Process.kill(:QUIT, $$)
     end
     false
   end
-- 
EW


                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151015013733.27968-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=rainbows-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Rainbows! Rack HTTP server user/dev discussion

Archives are clonable:
	git clone --mirror https://bogomips.org/rainbows-public
	git clone --mirror http://ou63pmih66umazou.onion/rainbows-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.rainbows

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox