Rainbows! Rack HTTP server user/dev discussion
 help / Atom feed
From: Claudio Poli <claudio-3HQ/CcOImoi171pxa8y+qA@public.gmane.org>
To: Rainbows! list <rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org>
Subject: Re: How to manage growing memory with Rainbows!
Date: Thu, 14 Feb 2013 07:58:17 +0100
Message-ID: <B3ED3231-62E8-4FF5-A65A-859AFD790C2B@gmail.com> (raw)
In-Reply-To: <20130212050021.GA18443-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>

Il giorno 12/feb/2013, alle ore 06:00, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> ha scritto:

Hello Eric,

> I'm curious, what tweaks did you try?

Measuring average memory in requests and tweaking RUBY_HEAP_MIN_SLOTS, RUBY_GC_MALLOC_LIMIT, RUBY_HEAP_FREE_MIN, etc.
Using LD_PRELOAD with libtcmalloc
Inviting Ruby (1.9.3) to perform GC after some heavy task.
Profiling application under multiple ruby/jruby versions to no avail.
Symbols vs string where applicable, etc.

> What kind of workload are you running? (many disk writes at all?)

No, it's quite a large Rails 3.2 app but we offload this kind of tasks to node.js in our architecture, which is able to operate under 80MB single instance.
Our ruby app serves json requests (api) and does the frontend.

> Which version of Ruby are you using?

Tried all the 1.9.3 patchsets, railsexpress, falcon patches..

> Are you counting VMSize or RSS?

Resident size

> Are you on 64-bit?

No, we were on 64bit but we switched to 32 bit.

> Fwiw, virtual memory usage is very high on 64-bit Linux on newer
> versions of glibc, but mostly harmless since the memory isn't actually
> used (address space is nearly unlimited).
> 
> You can try MALLOC_ARENA_MAX_=1 to limit the number of arenas if you
> want.  That might reduce fragmentation since the GVL in MRI means
> it's unlikely to hit malloc lock contention (glibc uses multiple
> malloc arenas to avoid contention by default).

I didn't knew about this setting, might be worth a try, thanks.

> OobGC is absolutely not recommended for Rainbows! (or anything doing
> persistent connections or simultaneous clients within a process)

Good to know.

> However, you can safely send SIGQUIT to any Rainbows! worker (bypassing
> master) whenever you feel memory usage is high, master will restart it.

Will Rainbows! wait after the last request before restarting?

> You can just put a simple counter in middleware to do it, something
> like this:
> 
> # nr is initialized to a number of your choice elsewhere
> 
> 	nr -= 1
> 	if nr < 0
> 	  Process.kill(:QUIT, $$)
> 	end
> 

Nice

> The best solution is to fix your code/gems/Ruby :)
> 
> I report and fix all the memory leaks I can find in gems+MRI.
> 
> One thing to avoid is allocating too much memory in the first place
> (always use LIMIT in SQL SELECT statements, read files in smaller
> chunks, etc).  It really takes only one poorly thought-out line of
> code to either OOM or cause a swap storm.

I agree, I'm not really saying I did everything possible but our project uses a lot of gems and I'm confident our ruby code is written fairly well (100% tested, although it doesn't mean anything in this case, easy methods, not really any black magic involved).
Leak might be in some gem but so far I haven't been able to spot anything remotely useful. I fear installing new relic since every day I read obscure problems caused by it and I had some myself.

> I haven't hit one of these problems in a while, but check out
> commit f95113402b7239f225282806673e1b6424522b18 in
> git://github.com/rack/rack.git for an example of how IO#gets
> can ruin your app.

Thanks for the example.
What Rainbows! strategy would you run on 1.9.3 given that some API call might take 800ms/1200ms (uncached) and the number of requests is fairly high?
Not only we are memory constrained but we are also trying to keep the costs down, the instance is a 4GB c1.medium on EC2, 1 core. Very underpowered as we tend to scale horizontally.
Considering a powerful VPS instead at the moment, since we'll prolly have to support 300k users very soon.

Thanks!
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


  parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12  4:19 Claudio Poli
     [not found] ` <E326380F-0B96-4B17-B721-DB814415E03E-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-12  5:00   ` Eric Wong
     [not found]     ` <20130212050021.GA18443-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2013-02-14  6:58       ` Claudio Poli [this message]
     [not found]         ` <B3ED3231-62E8-4FF5-A65A-859AFD790C2B-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-14  7:15           ` Eric Wong
     [not found]             ` <20130214071512.GA10890-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2013-02-14  8:49               ` Claudio Poli
     [not found]                 ` <F6728D3D-3E35-488B-8165-EB80E25FFF1B-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-14 20:28                   ` Eric Wong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B3ED3231-62E8-4FF5-A65A-859AFD790C2B@gmail.com \
    --to=claudio-3hq/ccoimoi171pxa8y+qa@public.gmane.org \
    --cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Rainbows! Rack HTTP server user/dev discussion

Archives are clonable:
	git clone --mirror https://bogomips.org/rainbows-public
	git clone --mirror http://ou63pmih66umazou.onion/rainbows-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.rainbows

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox