Rainbows! Rack HTTP server user/dev discussion
 help / Atom feed
From: "Lin Jen-Shin (godfat)" <godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org>
To: rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
Subject: Re: negative timeout in Rainbows::Fiber::Base
Date: Sun, 26 Aug 2012 08:12:52 +0800
Message-ID: <CAA2_N1uhfcHDbTvY+ke0Cid6=i7KEhFn8jvEirx+ptYVDacdvA@mail.gmail.com> (raw)
In-Reply-To: <20120825024556.GA25977-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>

On Sat, Aug 25, 2012 at 10:45 AM, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> The original code looks wrong and confusing :x

I guess I know your intension in the new code now :)
I can't apply the new patch, so I'll assume the new
code is as following:

    fibs.each { |fib| fib.resume }

    max_sleep = 1.0
    if max
      max -= Time.now
      return 0 if max < 0.0
      return max_sleep if max > max_sleep
      max
    else
      max_sleep
    end

I once thought that if `max < Time.now`, it should return 0,
because apparently we don't want to wait in this case.
But I am not sure if passing timeout as 0 would mean to
wait forever... thinking that maybe 0.0001 might be better?
Not sure if this would be a concern, or 0 means don't wait
at all, that would be ideal in this case.

> It's been a while since I've looked hard at the Fiber* stuff (not a fan
> of it personally).  However, I don't think abs() is correct, either.

I can smell from the code that those are not well polished,
since it seems a lot of things are missing. For example,
there is Rainbows::Fiber::IO::Socket, but no TCPSocket.
I blindly tried to create a TCPSocket version by creating
a new class extended from Kgio::TCPSocket and include
Rainbows::Fiber::IO::Methods.

Well, I think it works, if using correctly, for example it
does not accept domain names as built-in TCPSocket,
and not all of the methods are respecting fibers.

But I like the idea to patch the socket, that way, we can
turn existing library to run under certain network architecture.
For instance, this HTTP client accepts passing different
socket class:
https://github.com/tarcieri/http/blob/master/lib/http/options.rb#L33-37

    @default_socket_class = TCPSocket
    @default_ssl_socket_class = OpenSSL::SSL::SSLSocket

    class << self
      attr_accessor :default_socket_class, :default_ssl_socket_class

I didn't try if passing Rainbows' fiber sockets would work or not,
but I think in theory it should work. I think Tony did this for his:
https://github.com/celluloid/celluloid-io
Quoted from README:

"""
Replacement classes: Celluloid::IO includes replacements for the core
TCPServer and TCPSocket classes which automatically use an evented
mode inside of Celluloid::IO actors. They're named
Celluloid::IO::TCPServer and Celluloid::IO::TCPSocket, so they're
automatically available inside your class when you include
Celluloid::IO.
"""

Not sure if this is the way to go, but an interesting idea. At least
better than implementing every single client in both eventmachine
and built-in sockets I guess...

So speaking to celluloid-io, there's already Revactor and Coolio
support, what about celluloid-io? Last time I tried Coolio,
occasionally it would crash with internal assertion failures...
I would love to see if there's other alternatives to eventmachine.

Also, there is CoolioFiberSpawn, CoolioThreadPool and so on
so forth, why not EventMachineFiberSpawn and EventMachineThreadPool?
Actually we are running EventMachineFiberSpawn on production
at the moment, as shown in:

https://github.com/cardinalblue/rest-more/blob/master/example/rainbows.rb#L15-19
class REMFClient < Rainbows::EventMachine::Client
  def app_call input
    Fiber.new{ super }.resume
  end
end

(well, neverblock works too, but it doesn't seem to be
maintained now and I don't understand why it's a gem
with a lot of codes but not as simple as above. As this
sense, I feel async_sinatra is so wrong, but not sure
if I missed something here.)

It works great for us at the moment, though I am thinking about
switching to threads, too, since it's a lot more flexible than fibers.

Sorry that I might be asking too many questions in a single thread.
If you're interested in how I am testing them, I put my testing codes
at: https://github.com/godfat/ruby-server-exp
I am thinking about if I should be giving a talk on rubyconf.tw
about ruby application servers, promoting unicorn family.
It is one of the reasons to try out all of the options.

Thanks for your time :D
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


  parent reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23 20:36 Lin Jen-Shin (godfat)
     [not found] ` <CAA2_N1unOXb7Z4Jr8oKoSLu266O9Ko4o=oWzAcMA1w3=9X74KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-25  2:45   ` Eric Wong
     [not found]     ` <20120825024556.GA25977-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-08-26  0:12       ` Lin Jen-Shin (godfat) [this message]
     [not found]         ` <CAA2_N1uhfcHDbTvY+ke0Cid6=i7KEhFn8jvEirx+ptYVDacdvA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-26  1:15           ` Eric Wong
2012-08-29 16:00           ` Lin Jen-Shin (godfat)
     [not found]             ` <CAA2_N1thakAOVp7ibCNic+TjEVvXE0OGLgzXH3fJ1c2UTs68oQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-29 21:17               ` Eric Wong
     [not found]                 ` <20120829211707.GA22726-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-08-30 21:33                   ` Lin Jen-Shin (godfat)
     [not found]                     ` <CAA2_N1tc=Xx8WHaM8H=EWshyzGEyX04PnkdBGj9Jdb7cSzmbRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-31  1:37                       ` Eric Wong
     [not found]                         ` <20120831013731.GA16613-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-09-05 20:06                           ` Lin Jen-Shin (godfat)
     [not found]                             ` <CAA2_N1vfWXGw_CaaMWMijUSdMN2Pz882SYDtNEW2_6YWffgTKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-05 23:27                               ` Eric Wong
     [not found]                                 ` <20120905232739.GA25153-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-09-22  9:52                                   ` Lin Jen-Shin (godfat)
     [not found]                                     ` <CAA2_N1v460utbL31Qu-JbGuUxav1hY4X5+cEf=Mp2rOC5efzMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-22 19:42                                       ` Eric Wong
     [not found]                                         ` <20120922194222.GA6839-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-09-28 15:14                                           ` Lin Jen-Shin (godfat)
     [not found]                                             ` <CAA2_N1usHJVZgn5n7RaTyDCbK7eu6G4ocZAsvqsVeL6cPERskw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-28 19:11                                               ` Eric Wong
     [not found]                                                 ` <20120928191132.GA14292-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-09-28 19:24                                                   ` Eric Wong
     [not found]                                                     ` <20120928192449.GB14292-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-10-31  0:14                                                       ` Lin Jen-Shin (godfat)
2012-12-18 11:09                                                       ` Lin Jen-Shin (godfat)
     [not found]                                                         ` <CAA2_N1tcA-HK20C8Ok1Lv9KWwMD4fctCOPHTLeD9ayRJqWby1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-18 19:19                                                           ` Eric Wong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA2_N1uhfcHDbTvY+ke0Cid6=i7KEhFn8jvEirx+ptYVDacdvA@mail.gmail.com' \
    --to=godfat-hoe/xeebyyidnm+yrofe0a@public.gmane.org \
    --cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Rainbows! Rack HTTP server user/dev discussion

Archives are clonable:
	git clone --mirror https://bogomips.org/rainbows-public
	git clone --mirror http://ou63pmih66umazou.onion/rainbows-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.rainbows

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox