Rainbows! Rack HTTP server user/dev discussion
 help / Atom feed
From: "Lin Jen-Shin (godfat)" <godfat-hOE/xeEBYYIdnm+yROfE0A@public.gmane.org>
To: "Rainbows! list" <rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org>
Subject: Re: [PATCH] close_connection_after_writing only if not deferred, as in cool.io
Date: Fri, 28 Dec 2012 12:45:24 +0800
Message-ID: <CAA2_N1ujCb8Yt4FGJNaTN0FdSk6g_iqL5N747Vcxt5etp9RnMw@mail.gmail.com> (raw)
In-Reply-To: <20121218235954.GA14404-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>

On Wed, Dec 19, 2012 at 7:59 AM, Eric Wong <normalperson-rMlxZR9MS24@public.gmane.org> wrote:
> I've had no trouble running tests with various Linux distros.
> It's been a long time since I've tested on FreeBSD, and I've
> not tested on any other *BSD.  I cannot support non-Free OSes.
>
> Anything in the *err logs?  The tests should leave them around on
> failure.

>From last time I checked, there's nothing left in the log. I would
guess it's because some command line tools behave differently,
but Rainbows should work fine.

Here's what I need to comment out: (3 tests, ab, rack-fiber_pool,
and "Content-Length is set correctly in headers" (I guess it's grep
behave differently. I could try to install GNU's version and try again.)

diff --git a/t/t0012-spurious-wakeups-quiet.sh
b/t/t0012-spurious-wakeups-quiet.sh
index 23557b7..b63870f 100755
--- a/t/t0012-spurious-wakeups-quiet.sh
+++ b/t/t0012-spurious-wakeups-quiet.sh
@@ -10,11 +10,11 @@ then
 	AB=$(PATH=/usr/local/sbin:/usr/sbin:$PATH which ab 2>/dev/null || :)
 fi

-if test -z "$AB"
-then
+#if test -z "$AB"
+#then
 	t_info "skipping $T since 'ab' could not be found"
 	exit 0
-fi
+#fi

 t_plan 4 "quiet spurious wakeups for $model"
diff --git a/t/t0600-rack-fiber_pool.sh b/t/t0600-rack-fiber_pool.sh
index 01f28b5..ca8fcb1 100755
--- a/t/t0600-rack-fiber_pool.sh
+++ b/t/t0600-rack-fiber_pool.sh
@@ -10,7 +10,7 @@ esac

 require_check rack/fiber_pool Rack::FiberPool

-t_plan 7 "basic test with rack-fiber_pool gem"
+t_plan 6 "basic test with rack-fiber_pool gem"

 CONFIG_RU=rack-fiber_pool/app.ru

@@ -42,8 +42,8 @@ t_begin "no errors from curl" && {

 t_begin "no errors in stderr" && check_stderr

-t_begin "ensure we hit 3 separate fibers" && {
-	test x3 = x"$(sort < $curl_out | uniq | wc -l)"
-}
+# t_begin "ensure we hit 3 separate fibers" && {
+# 	test x3 = x"$(sort < $curl_out | uniq | wc -l)"
+# }

 t_done
diff --git a/t/t9001-sendfile-to-path.sh b/t/t9001-sendfile-to-path.sh
index 5a9fdcd..7ca450a 100755
--- a/t/t9001-sendfile-to-path.sh
+++ b/t/t9001-sendfile-to-path.sh
@@ -2,7 +2,7 @@
 . ./test-lib.sh
 skip_models StreamResponseEpoll

-t_plan 7 "Sendfile middleware test for $model"
+t_plan 6 "Sendfile middleware test for $model"

 t_begin "configure and start" && {
 	rtmpfiles curl_err
@@ -39,9 +39,9 @@ t_begin "X-Sendfile does not show up in headers" && {
 	fi
 }

-t_begin "Content-Length is set correctly in headers" && {
-	expect=$(wc -c < random_blob)
-	grep "^< Content-Length: $expect" $curl_err
-}
+# t_begin "Content-Length is set correctly in headers" && {
+# 	expect=$(wc -c < random_blob)
+# 	grep "^< Content-Length: $expect" $curl_err
+# }

 t_done
_______________________________________________
Rainbows! mailing list - rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org
http://rubyforge.org/mailman/listinfo/rainbows-talk
Do not quote signatures (like this one) or top post when replying


  parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAA2_N1tHbvs=J--dPZLnq6_owEx3JJZbFoRzjFKcCLBONW=iGA@mail.gmail.com>
     [not found] ` <CAA2_N1s+SefHd7Dotw53+5b=-EeBt_O5Q-LmoKuUy65jZiZ+tA@mail.gmail.com>
     [not found]   ` <CAA2_N1s+SefHd7Dotw53+5b=-EeBt_O5Q-LmoKuUy65jZiZ+tA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-18 20:36     ` Lin Jen-Shin (godfat)
     [not found]       ` <CAA2_N1scEcW3J=4dmUVvd+UgLwuayqkpfjNfVGLCJw-dXm9_cA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-18 21:45         ` Eric Wong
     [not found]           ` <20121218214538.GA12275-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-12-18 22:20             ` Lin Jen-Shin (godfat)
     [not found]               ` <CAA2_N1ur-dxw4i9dvMhTNAcskJe+N=4hU2Yuq341TxvJ2KE4kw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-18 23:59                 ` Eric Wong
     [not found]                   ` <20121218235954.GA14404-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-12-28  4:45                     ` Lin Jen-Shin (godfat) [this message]
     [not found]                       ` <CAA2_N1ujCb8Yt4FGJNaTN0FdSk6g_iqL5N747Vcxt5etp9RnMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-28  8:43                         ` Eric Wong
     [not found]                           ` <20121228084337.GB19512-yBiyF41qdooeIZ0/mPfg9Q@public.gmane.org>
2012-12-28 11:26                             ` Lin Jen-Shin (godfat)
     [not found]                               ` <CAA2_N1tCYbJjh_NvdVOQzJ5hvdv5NYnBM+VhP105uRvCzbnF_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-29 13:26                                 ` Eric Wong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/rainbows/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA2_N1ujCb8Yt4FGJNaTN0FdSk6g_iqL5N747Vcxt5etp9RnMw@mail.gmail.com \
    --to=godfat-hoe/xeebyyidnm+yrofe0a@public.gmane.org \
    --cc=rainbows-talk-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Rainbows! Rack HTTP server user/dev discussion

Archives are clonable:
	git clone --mirror https://bogomips.org/rainbows-public
	git clone --mirror http://ou63pmih66umazou.onion/rainbows-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.rainbows
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.rainbows

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox