From 23921538a108ab7aeb5b2654b58101e15259238f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 26 Nov 2009 22:55:11 -0800 Subject: RevThreadSpawn: hope for 1.8 performance Patches submitted to rev-talk, awaiting feedback and hopefully a new release. --- Documentation/comparison.haml | 11 +++++++++-- lib/rainbows/rev_thread_spawn.rb | 5 +++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/Documentation/comparison.haml b/Documentation/comparison.haml index 03661f8..400e020 100644 --- a/Documentation/comparison.haml +++ b/Documentation/comparison.haml @@ -53,7 +53,7 @@ %tr.comp_row %td.mod RevThreadSpawn %td.tee No - %td.r18 Slow + %td.r18 Slow* %td.r19 Yes %td.rbx No %td.slow Yes @@ -72,7 +72,14 @@ %td.rbx Yes %td.slow Yes %ul - %li waiting on Rubinius for better signal handling + %li + RevThreadSpawn + 1.8 performance is being improved, follow + the + %a(href="http://rubyforge.org/mailman/listinfo/rev-talk") + rev-talk mailing list + for details. + %li + waiting on Rubinius for better signal handling %li rack.input streaming is what makes %a(href="http://upr.bogomips.org/") upload progress, diff --git a/lib/rainbows/rev_thread_spawn.rb b/lib/rainbows/rev_thread_spawn.rb index f2ce822..ae7ff79 100644 --- a/lib/rainbows/rev_thread_spawn.rb +++ b/lib/rainbows/rev_thread_spawn.rb @@ -1,8 +1,9 @@ # -*- encoding: binary -*- require 'rainbows/rev' -RUBY_VERSION =~ %r{\A1\.8} and - warn "Rainbows::RevThreadSpawn does not work well under Ruby 1.8" +RUBY_VERSION =~ %r{\A1\.8} && ::Rev::VERSION < "0.3.2" and + warn "Rainbows::RevThreadSpawn + Rev (< 0.3.2)" \ + " does not work well under Ruby 1.8" module Rainbows -- cgit v1.2.3-24-ge0c7