From 9e7fb4e9b5d97cc75892c8faaea46444d438eb61 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 21 Nov 2015 08:52:28 +0000 Subject: tiny bytecode reductions for cold paths Less code in cold paths can improve speed for hot paths. Single-byte strings for String#split is optimized in mainline Ruby, so it's not actually a performance loss for sendfile_range in response.rb Regexps are at least 400 bytes each, so prefer non-Regexps if possible, especially for cold sites where performance does not matter. --- lib/rainbows/response.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/rainbows/response.rb') diff --git a/lib/rainbows/response.rb b/lib/rainbows/response.rb index 3e48c65..ac50321 100644 --- a/lib/rainbows/response.rb +++ b/lib/rainbows/response.rb @@ -40,7 +40,7 @@ module Rainbows::Response else if /\n/ =~ value # avoiding blank, key-only cookies with /\n+/ - buf << value.split(/\n+/).map! { |v| "#{key}: #{v}\r\n" }.join + value.split(/\n+/).each { |v| buf << "#{key}: #{v}\r\n" } else buf << "#{key}: #{value}\r\n" end @@ -151,7 +151,7 @@ module Rainbows::Response 200 == status && /\Abytes=(\d+-\d*|\d*-\d+)\z/ =~ @hp.env['HTTP_RANGE'] or return - a, b = $1.split(/-/) + a, b = $1.split('-'.freeze) # HeaderHash is quite expensive, and Rack::File currently # uses a regular Ruby Hash with properly-cased headers the -- cgit v1.2.3-24-ge0c7