From b933b1607db5438e424b323c297b57c680587ed7 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Mon, 9 Nov 2009 12:03:23 -0800 Subject: rev_thread_spawn: 16K chunked reads work better When reading 4K chunks, performance is dismal under 1.8 --- lib/rainbows/rev_thread_spawn.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'lib/rainbows/rev_thread_spawn.rb') diff --git a/lib/rainbows/rev_thread_spawn.rb b/lib/rainbows/rev_thread_spawn.rb index 4eba6d9..b8aa420 100644 --- a/lib/rainbows/rev_thread_spawn.rb +++ b/lib/rainbows/rev_thread_spawn.rb @@ -18,9 +18,13 @@ module Rainbows # # Caveats: # - # * TeeInput performance is terrible unless you match the - # length argument of your env["rack.input"]#read calls - # so that it is equal to Rev::IO::INPUT_SIZE + # * TeeInput performance under Ruby 1.8 is terrible unless you + # match the length argument of your env["rack.input"]#read + # calls so that it is greater than or equal to Rev::IO::INPUT_SIZE. + # Most applications depending on Rack to do multipart POST + # processing should be alright as the current Rev::IO::INPUT_SIZE + # of 16384 bytes matches the read size used by + # Rack::Utils::Multipart::parse_multipart. module RevThreadSpawn class Client < Rainbows::Rev::Client -- cgit v1.2.3-24-ge0c7