From 36ce10c49ce7aa0df9d47f5a5f870c23c1891258 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 30 Jun 2012 19:57:08 +0000 Subject: coolio+xepoll_thread*: use shutdown() for keepalive timeout Triggering Errno::EBADF is tricky in multithreaded situations due to possible race conditions and yet-to-be discovered bugs. shutdown(2) is also safe against apps the fork() internally but do not execve(2) nor set FD_CLOEXEC. n.b. calling fork() after pthreads are spawned may not be safe on all platforms w.r.t. malloc, but /is/ the case for glibc on GNU/Linux. Follow-up-to: commit a5b987619f4b793203f6a50e424fe98c5b0794ba --- lib/rainbows/xepoll_thread_pool/client.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/rainbows/xepoll_thread_pool') diff --git a/lib/rainbows/xepoll_thread_pool/client.rb b/lib/rainbows/xepoll_thread_pool/client.rb index 759202b..61b0b68 100644 --- a/lib/rainbows/xepoll_thread_pool/client.rb +++ b/lib/rainbows/xepoll_thread_pool/client.rb @@ -77,7 +77,7 @@ module Rainbows::XEpollThreadPool::Client LOCK.synchronize do KATO.delete_if { |client, time| time < ot and defer << client } end - defer.each { |io| io.closed? or io.close } + defer.each { |io| io.closed? or io.shutdown } end @@last_expire = now end -- cgit v1.2.3-24-ge0c7