From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, T_RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: raindrops-public@bogomips.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id B29EE1F4E1; Wed, 14 Jan 2015 00:25:13 +0000 (UTC) From: Eric Wong To: raindrops-public@bogomips.org Cc: Eric Wong Subject: [PATCH] linux_inet_diag: clarify *fprintf usage without GVL Date: Wed, 14 Jan 2015 00:25:12 +0000 Message-Id: <1421195112-22633-1-git-send-email-e@80x24.org> X-Mailer: git-send-email 2.2.0.35.g882592c List-Id: A reviewer may wonder why fprintf is chosen instead of rb_warn, so make it clear we're outside of the GVL when spewing the warning message and cannot use most rb_* functions. --- ext/raindrops/linux_inet_diag.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/ext/raindrops/linux_inet_diag.c b/ext/raindrops/linux_inet_diag.c index fa8de03..5f21295 100644 --- a/ext/raindrops/linux_inet_diag.c +++ b/ext/raindrops/linux_inet_diag.c @@ -1,4 +1,5 @@ #include +#include #ifdef HAVE_RUBY_ST_H # include #else @@ -213,8 +214,14 @@ static const char *addr_any(sa_family_t family) return ipv6; } -static void bug_warn(void) +static void bug_warn_nogvl(const char *fmt, ...) { + va_list ap; + + va_start(ap, fmt); + vfprintf(stderr, fmt, ap); + va_end(ap); + fprintf(stderr, "Please report how you produced this at "\ "raindrops-public@bogomips.org\n"); fflush(stderr); @@ -263,8 +270,7 @@ static struct listen_stats *stats_for(st_table *table, struct inet_diag_msg *r) assert(0 && "unsupported address family, could that be IPv7?!"); } if (rc != 0) { - fprintf(stderr, "BUG: getnameinfo: %s\n", gai_strerror(rc)); - bug_warn(); + bug_warn_nogvl("BUG: getnameinfo: %s\n", gai_strerror(rc)); *key = 0; } @@ -296,8 +302,7 @@ static struct listen_stats *stats_for(st_table *table, struct inet_diag_msg *r) addr_any(sa.ss.ss_family), ntohs(r->id.idiag_sport)); if (n <= 0) { - fprintf(stderr, "BUG: snprintf: %d\n", n); - bug_warn(); + bug_warn_nogvl("BUG: snprintf: %d\n", n); } if (st_lookup(table, (st_data_t)key, (st_data_t *)&stats)) return stats; -- EW