raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: raindrops@librelist.org
Subject: Re: [PATCH] Add method_missing to Raindrops::Middleware::Proxy
Date: Fri, 18 May 2012 04:27:00 +0000
Message-ID: <20120518042700.GA20534@dcvr.yhbt.net> (raw)
In-Reply-To: <CAO1NZAoKvBjAQY2DJSUQYF3TXRDrS4-muX_d=HiiUQRDNQ+W7g@mail.gmail.com>

Ben Somers <somers.ben@gmail.com> wrote:
> > Sorry :x  I try to follow the contribution guidelines as git itself and
> > I think the README makes that much clear.  Patches to clarify what you
> > think needs clarifying also appreciated :)
> 
> Hah, still pretty clear. I'm just used to working on github-hosted
> projects, where pull requests are the norm. Sitting down and reading
> through git's guidelines takes a minute.

Cool, thanks for taking the time, though :)

> > Let me know if you think my comment for method_missing is better.
> > (often things I say which I /think/ makes sense... don't :D)
> 
> I agree, I like your version better. And I think the blank line was an
> accident anyway :)

Pushed.  I'm thinking about making another raindrops release in the next
day or two for this.  Any other changes?


I'm not sure if I'll get to the unix_diag addition that landed in
Linux 3.3 (any takers? :).  unix_diag can wait since it'll be a while
before people upgrade to 3.3.  (I still support systems on 2.6.18).

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  1:46 Ben Somers
2012-05-18  2:35 ` Eric Wong
2012-05-18  3:56   ` Ben Somers
2012-05-18  4:27     ` Eric Wong [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120518042700.GA20534@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=raindrops@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

raindrops RubyGem user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://bogomips.org/raindrops-public
	git clone --mirror http://ou63pmih66umazou.onion/raindrops-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.raindrops
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.raindrops

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox