From: Eric Wong <normalperson@yhbt.net>
To: raindrops@librelist.org
Subject: Re: [PATCH] ...
Date: Tue, 5 Jun 2012 17:15:34 -0700 [thread overview]
Message-ID: <20120606001534.GA28607@dcvr.yhbt.net> (raw)
In-Reply-To: CALO9HP0mwg54Eq_dHZw9T2oELMmpj3XEzJdrr3R2sk5XPsD3mg@mail.gmail.com
Brian Corrigan <brian@genexp.me> wrote:
> Hey Eric - can you take it for here? Also, thanks for the patience :).
> Fwiw, it's cool to have code in this project. I learned a lot by reviewing
> the source.
Sure thing. Btw, don't top post and don't send HTML parts. There's a
lot of technical mailing lists that don't welcome these things.
Actually, did you get the test you added running at all?
File.symlink returns 0 on success, so using the return value is bogus.
I'll rewrite it an squash a patch on top of it.
next prev parent reply other threads:[~2012-06-06 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 15:46 [PATCH] Raindrops currently fails when provided a symlink to a socket. As this is a common practice for many deployment tools (Vlad, etc.) this patch adds support for finding the realpath prior to looking the socket up in /proc/net/unix Brian Corrigan
2012-06-05 17:57 ` [PATCH] Eric Wong
2012-06-05 23:59 ` [PATCH] Brian Corrigan
2012-06-06 0:15 ` Eric Wong [this message]
2012-06-06 0:49 ` [PATCH] Eric Wong
2012-06-06 0:50 ` [PATCH] Brian Corrigan
2012-06-06 0:56 ` [PATCH] unix_listener_stats follows and remembers symlinks Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/raindrops/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120606001534.GA28607@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=raindrops@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).