[PATCH] middleware/proxy: favor __send__ for method dispatch

[PATCH] middleware/proxy: favor __send__ for method dispatch

[Eric Wong]

"send" is more likely to be overridden in subclasses whereas
the Ruby runtime (at least 1.9.3) will warn loudly if any user
code (re)defines the "__send__" method.

For example, BasicSocket#send and UDPSocket#send in the Ruby
stdlib are wrappers for the send(2)/sendto(2) system calls,
and it's entirely possible an application could return a
Socket-subclass as a Rack response body.
---
 Pushed to "master" of git://bogomips.org/raindrops

 lib/raindrops/middleware/proxy.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/raindrops/middleware/proxy.rb b/lib/raindrops/middleware/proxy.rb
index ce634bb..1cf437c 100644
--- a/lib/raindrops/middleware/proxy.rb
+++ b/lib/raindrops/middleware/proxy.rb
@@ -35,6 +35,6 @@ class Raindrops::Middleware::Proxy
   # Avoid breaking users of non-standard extensions (e.g. #body)
   # Rack::BodyProxy does the same.
   def method_missing(*args, &block)
-    @body.send(*args, &block)
+    @body.__send__(*args, &block)
   end
 end
-- 
1.7.11.rc0.55.gb2478aa

Re: [PATCH] middleware/proxy: favor __send__ for method dispatch

[Ben Somers]

> "send" is more likely to be overridden in subclasses whereas
> the Ruby runtime (at least 1.9.3) will warn loudly if any user
> code (re)defines the "__send__" method.

This seems eminently sensible and IIRC is the same way Rack does it.
Not sure why I changed it when making the original commit, I would
suspect my own foolishness.