raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / Atom feed
* [PATCH] linux_inet_diag: improve compatibility with newer GCs
@ 2013-06-16 20:59 Eric Wong
  2013-08-31  6:02 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2013-06-16 20:59 UTC (permalink / raw)
  To: raindrops

RARRAY_PTR is expensive with GCs in Ruby 2.1.0dev and Rubinius, so
use rb_ary_entry for non-performance critical paths.  Eventually,
RARRAY_AREF/RARRAY_ASET may be common, but for now, using
rb_ary_entry should require the least cognitive overhead for a
developer.
---
  Pushed to "gc-next" of git://bogomips.org/raindrops.git

 ext/raindrops/linux_inet_diag.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/ext/raindrops/linux_inet_diag.c b/ext/raindrops/linux_inet_diag.c
index dcf7bc2..cd4a876 100644
--- a/ext/raindrops/linux_inet_diag.c
+++ b/ext/raindrops/linux_inet_diag.c
@@ -586,8 +586,6 @@ static VALUE tcp_stats(struct nogvl_args *args, VALUE addr)
  */
 static VALUE tcp_listener_stats(int argc, VALUE *argv, VALUE self)
 {
-	VALUE *ary;
-	long i;
 	VALUE rv = rb_hash_new();
 	struct nogvl_args args;
 	VALUE addrs, sock;
@@ -610,20 +608,26 @@ static VALUE tcp_listener_stats(int argc, VALUE *argv, VALUE self)
 	case T_STRING:
 		rb_hash_aset(rv, addrs, tcp_stats(&args, addrs));
 		return rv;
-	case T_ARRAY:
-		ary = RARRAY_PTR(addrs);
-		i = RARRAY_LEN(addrs);
-		if (i == 1) {
-			rb_hash_aset(rv, *ary, tcp_stats(&args, *ary));
+	case T_ARRAY: {
+		long i;
+		long len = RARRAY_LEN(addrs);
+		VALUE cur;
+
+		if (len == 1) {
+			cur = rb_ary_entry(addrs, 0);
+
+			rb_hash_aset(rv, cur, tcp_stats(&args, cur));
 			return rv;
 		}
-		for (; --i >= 0; ary++) {
+		for (i = 0; i < len; i++) {
 			union any_addr check;
+			VALUE cur = rb_ary_entry(addrs, i);
 
-			parse_addr(&check, *ary);
-			rb_hash_aset(rv, *ary, Qtrue);
+			parse_addr(&check, cur);
+			rb_hash_aset(rv, cur, Qtrue);
 		}
 		/* fall through */
+	}
 	case T_NIL:
 		args.table = st_init_strtable();
 		gen_bytecode_all(&args.iov[2]);
-- 
Eric Wong


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] linux_inet_diag: improve compatibility with newer GCs
  2013-06-16 20:59 [PATCH] linux_inet_diag: improve compatibility with newer GCs Eric Wong
@ 2013-08-31  6:02 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2013-08-31  6:02 UTC (permalink / raw)
  To: raindrops

Eric Wong <normalperson@yhbt.net> wrote:
> RARRAY_PTR is expensive with GCs in Ruby 2.1.0dev and Rubinius, so
> use rb_ary_entry for non-performance critical paths.  Eventually,
> RARRAY_AREF/RARRAY_ASET may be common, but for now, using
> rb_ary_entry should require the least cognitive overhead for a
> developer.
> ---
>   Pushed to "gc-next" of git://bogomips.org/raindrops.git

Cherry-picked into master, will release 0.12.0 this weekend unless
there are objections.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-16 20:59 [PATCH] linux_inet_diag: improve compatibility with newer GCs Eric Wong
2013-08-31  6:02 ` Eric Wong

raindrops RubyGem user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://bogomips.org/raindrops-public
	git clone --mirror http://ou63pmih66umazou.onion/raindrops-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.raindrops
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.raindrops

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox