raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: raindrops@librelist.org
Subject: Re: [PATCH 2/2] Return real stats instead of True
Date: Mon, 9 Sep 2013 19:44:49 +0000	[thread overview]
Message-ID: <20130909194449.GA16692@dcvr.yhbt.net> (raw)
In-Reply-To: CAAB-KckpMYtQo3yeXAu1Su=Up+_g8vyU23DNPYBojwdtFCEy5A@mail.gmail.com

Hleb Valoshka <375gnu@gmail.com> wrote:
> On 9/9/13, Eric Wong <normalperson@yhbt.net> wrote:
> > This deserves an explanation (and ideally, a test case).  I haven't
> > looked at the code in a while and needed to think a bit about
> > when the fix is relevant.
> 
> You better reject it. I've made it because of test failure:

Ah, thanks.  I've been forgetting to test on IPv6-enabled systems :x

(I typically run custom kernels without IPv6, there were
 compatibility/slowdown issues (way) back in the day and it was
 easier to just not enable IPv6 at all.
 Probably moot at this point...)

> But the real reason may be something else: I've got IPv6 address using
> Teredo and getnameinfo returns error with it. So it cause other
> errors, I need to check it better.

OK.


  reply	other threads:[~2013-09-09 19:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-09 19:03 [PATCH 1/2] Add setup and teardown for ipv6 tests Hleb Valoshka
2013-09-09 19:03 ` [PATCH 2/2] Return real stats instead of True Hleb Valoshka
2013-09-09 19:20   ` Eric Wong
2013-09-09 19:37     ` Hleb Valoshka
2013-09-09 19:44       ` Eric Wong [this message]
2013-09-09 20:35         ` Hleb Valoshka
2013-09-09 22:03           ` Eric Wong
2013-09-10  7:18             ` Hleb Valoshka
2016-02-25  9:54     ` Eric Wong
2014-11-14  3:15 ` [PATCH 1/2] Add setup and teardown for ipv6 tests Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130909194449.GA16692@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=raindrops@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/raindrops.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).