From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS47066 71.19.144.0/20 X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00, MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.raindrops.general Subject: Re: [PATCH 2/2] Return real stats instead of True Date: Mon, 9 Sep 2013 19:44:49 +0000 Message-ID: <20130909194449.GA16692@dcvr.yhbt.net> References: <1378753439-13495-1-git-send-email-375GNU@Gmail.COM> <1378753439-13495-2-git-send-email-375GNU@Gmail.COM> <20130909192020.GA18010@dcvr.yhbt.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1378755906 19590 80.91.229.3 (9 Sep 2013 19:45:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Sep 2013 19:45:06 +0000 (UTC) To: raindrops@librelist.org Original-X-From: raindrops@librelist.org Mon Sep 09 21:45:09 2013 Return-path: Envelope-to: gclrrg-raindrops@m.gmane.org List-Archive: List-Help: List-Id: List-Post: List-Subscribe: List-Unsubscribe: Precedence: list Original-Sender: raindrops@librelist.org Xref: news.gmane.org gmane.comp.lang.ruby.raindrops.general:126 Archived-At: Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VJ7OX-0001fE-8o for gclrrg-raindrops@m.gmane.org; Mon, 09 Sep 2013 21:45:09 +0200 Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by zedshaw2.xen.prgmr.com (Postfix) with ESMTP id A050A74E68 for ; Mon, 9 Sep 2013 19:54:32 +0000 (UTC) Hleb Valoshka <375gnu@gmail.com> wrote: > On 9/9/13, Eric Wong wrote: > > This deserves an explanation (and ideally, a test case). I haven't > > looked at the code in a while and needed to think a bit about > > when the fix is relevant. > > You better reject it. I've made it because of test failure: Ah, thanks. I've been forgetting to test on IPv6-enabled systems :x (I typically run custom kernels without IPv6, there were compatibility/slowdown issues (way) back in the day and it was easier to just not enable IPv6 at all. Probably moot at this point...) > But the real reason may be something else: I've got IPv6 address using > Teredo and getnameinfo returns error with it. So it cause other > errors, I need to check it better. OK.