raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / Atom feed
From: Antonio Terceiro <terceiro@softwarelivre.org>
To: Eric Wong <e@80x24.org>
Cc: raindrops-public@bogomips.org
Subject: Re: [RFC 2/1] linux: remove Pathname stdlib dependency
Date: Tue, 23 Feb 2016 08:00:48 -0300
Message-ID: <20160223110048.GC31015@softwarelivre.org> (raw)
In-Reply-To: <20160223020434.GA9948@dcvr.yhbt.net>

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

On Tue, Feb 23, 2016 at 02:04:34AM +0000, Eric Wong wrote:
> The File.readlink has been available since the earliest SVN import
> of Ruby from Jan 16 1998.  There's no reason to load the Pathname
> class here since we don't do any further pathname manipulation.
> 
> So avoid loading the extra .so here and creating extra objects.
> ---
>  Noticed while reviewing "[RFC] linux: workaround Ruby 2.3 change"
>  http://bogomips.org/raindrops-public/20160202183136.21549-1-e@80x24.org/raw
> 
>  lib/raindrops/linux.rb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/raindrops/linux.rb b/lib/raindrops/linux.rb
> index a38fa64..4166ec7 100644
> --- a/lib/raindrops/linux.rb
> +++ b/lib/raindrops/linux.rb
> @@ -8,7 +8,6 @@
>  # Instead of snapshotting, Raindrops::Aggregate::LastDataRecv may be used
>  # to aggregate statistics from +all+ accepted sockets as they arrive
>  # based on the +last_data_recv+ field in Raindrops::TCP_Info
> -require 'pathname'
>  
>  module Raindrops::Linux
>  
> @@ -46,7 +45,7 @@ module Raindrops::Linux
>          path.force_encoding(Encoding::BINARY) if defined?(Encoding)
>          if File.symlink?(path)
>            link = path
> -          path = Pathname.new(link).realpath.to_s
> +          path = File.readlink(link)
>            path.force_encoding(Encoding::BINARY) if defined?(Encoding)
>            rv[link] = rv[path] # vivify ListenerStats
>          else
> -- 
> EW

LGTM


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 820 bytes --]

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 18:31 [RFC] linux: workaround Ruby 2.3 change Eric Wong
2016-02-23  2:04 ` [RFC 2/1] linux: remove Pathname stdlib dependency Eric Wong
2016-02-23 11:00   ` Antonio Terceiro [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/raindrops/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160223110048.GC31015@softwarelivre.org \
    --to=terceiro@softwarelivre.org \
    --cc=e@80x24.org \
    --cc=raindrops-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

raindrops RubyGem user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://bogomips.org/raindrops-public
	git clone --mirror http://ou63pmih66umazou.onion/raindrops-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.raindrops
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.raindrops

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox