raindrops RubyGem user+dev discussion/patches/pulls/bugs/help
 help / Atom feed
* [PATCH] Properly override respond_to? in Raindrops::Middleware::Proxy
@ 2017-07-25 20:02 Dmytro Shteflyuk
  2017-07-25 21:38 ` Eric Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Dmytro Shteflyuk @ 2017-07-25 20:02 UTC (permalink / raw)
  To: raindrops-public; +Cc: Dmytro Shteflyuk

Correct method definition according to Ruby documentation (https://ruby-doc.org/core-2.4.1/Object.html#method-i-respond_to-3F) is:

    respond_to?(string, include_all=false) → true or false

Rack started using second argument starting from version 2:

https://github.com/rack/rack/blob/master/lib/rack/body_proxy.rb#L14

If raindrops is used in Rack 2+ applications, an exception is raised:

    ArgumentError: wrong number of arguments (2 for 1)
        <ROOT>/gems/raindrops-0.18.0/lib/raindrops/middleware/proxy.rb:30:in `respond_to?'
        <ROOT>/gems/rack-2.0.3/lib/rack/body_proxy.rb:14:in `respond_to?'
---
 lib/raindrops/middleware/proxy.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/raindrops/middleware/proxy.rb b/lib/raindrops/middleware/proxy.rb
index 1cf437c..a7c8e66 100644
--- a/lib/raindrops/middleware/proxy.rb
+++ b/lib/raindrops/middleware/proxy.rb
@@ -27,9 +27,9 @@ def to_path
 
   # Rack servers use +respond_to?+ to check for the presence of +close+
   # and +to_path+ methods.
-  def respond_to?(m)
+  def respond_to?(m, include_all = false)
     m = m.to_sym
-    :close == m || @body.respond_to?(m)
+    :close == m || @body.respond_to?(m, include_all)
   end
 
   # Avoid breaking users of non-standard extensions (e.g. #body)
-- 
2.13.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Properly override respond_to? in Raindrops::Middleware::Proxy
  2017-07-25 20:02 [PATCH] Properly override respond_to? in Raindrops::Middleware::Proxy Dmytro Shteflyuk
@ 2017-07-25 21:38 ` Eric Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2017-07-25 21:38 UTC (permalink / raw)
  To: Dmytro Shteflyuk; +Cc: raindrops-public

Thanks!  Pushed as 35561c491584a22b82dec5f37b84f792aa8a278b

Anything else?  I suppose we can should release 0.19.0 soon.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 20:02 [PATCH] Properly override respond_to? in Raindrops::Middleware::Proxy Dmytro Shteflyuk
2017-07-25 21:38 ` Eric Wong

raindrops RubyGem user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://bogomips.org/raindrops-public
	git clone --mirror http://ou63pmih66umazou.onion/raindrops-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.raindrops
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.raindrops

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox