Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno

[Eric Wong <e@80x24.org>]

Samuel Williams <samuel.williams@oriontransfer.co.nz> wrote:
> ---

Where's the commit message body?

At minimum, non-trivial commits must have an explanation of why
a change is necessary.  This is important to reviewers who don't
follow Ruby core development closely.


Even one sentence for the "why" is fine as long as it can be
meaningful to offline reviewers.  References to online sources are
fine (full URLs, not #NNN); but it needs to be accompanied by a
summary for offline users.  See `git log' for examples.

In the case of this patch; I would also like to know which Ruby
implementation(s) and version(s) it appears in; and evidence
backing up that it's a supported public API we can depend on
going forward.


On a side note, describing "what" you're doing file-by-file
is totally uninteresting when it's obvious from reading
the patch.  IOW, old ruby.git and GNU ChangeLog conventions
are a waste of time+effort for users with `git log -p'.


Please ensure HTML is off and keep raindrops-public Cc-ed in responses.

Thanks.