From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FAKE_REPLY_B,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=no autolearn_force=no version=3.4.6 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2DA771F542 for ; Sat, 10 Jun 2023 07:30:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=al0sqbtR; dkim-atps=neutral Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f7378a75c0so18198675e9.3 for ; Sat, 10 Jun 2023 00:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686382217; x=1688974217; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=A/RU3oGp90FqWrkty/YlEzESE/k1ihWceQvawTnqP50=; b=al0sqbtRDwbWKOvFBR92qd1FqlXeHH3+Syo9DVsGQevEvKy+P+JP4R744hhTbjzS/t PLPNKyrlPvIw323SfEO+AiJeHNLE1gA+Q4w60dZlvkBf0pqDh2HP+prcYsg+1M5a4ver sFsAfCOFXVX3dPRcSzfRb+uK6uM9fGrExizeVFRvUi63kMF4f/Q288wJIvEPwvXYojjG +wHIa/DzIujzqtfix+Acfz4w0nyry6y0opoXgrukji40siP99gxMxnq0EzfyD01qS1NU tpmzMNNc1KXzIE3G94RiuBwpq7UG6oKSGcQU+q/9UQB+tkoc5XZUvX9GQ3t4u8AcRGIW nxzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686382217; x=1688974217; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A/RU3oGp90FqWrkty/YlEzESE/k1ihWceQvawTnqP50=; b=B1If3ipxN4JcladSDPAUHLNFLzrD0J2QavvZrcFprymV3iwagX4fhi123sC3/NnO56 RQZcHabCakG5ar8/wOwcY/Dq3SWhn5zaKvztrploj/O/49AoLCguaH0sUGCFmKMMTWvP 0P2yB9DvnuItiGVwWRQho4IGaA6Tu8knTxAu0kR4NlcKue6rhGI/eOgyEc0K3z6ybm9z 5sn9S9XK7fdvTsJF8fmDag4a5zyZOYRLCCa6kqPxDGEQTwfwn11kuPamGpeox9fDfB8w buhN/B8P/5wODqDRX5ccQK0F91co66IUwAFNOWoWc00qLMg1exuwpOlvad26Wqji6s7Y rHKQ== X-Gm-Message-State: AC+VfDzd1qcLwpJFbNz/ahZaVpxc3kMm02/tXjbutLpgAXcijj349b/o NrTIIHm//S3J87EXK/jUPgZPoqTi06E= X-Google-Smtp-Source: ACHHUZ75irRDxnDssQyPZJw27GdlBO+SRpKZdwjaV7PLKNqVwrd+4/IhiD1MLtoJQNHa5a3RzNNEmw== X-Received: by 2002:a05:600c:2942:b0:3f8:f5d:52e7 with SMTP id n2-20020a05600c294200b003f80f5d52e7mr421389wmd.31.1686382217041; Sat, 10 Jun 2023 00:30:17 -0700 (PDT) Received: from smtpclient.apple ([2a01:e0a:2a1:c1c0:e95b:b350:3e2e:6651]) by smtp.gmail.com with ESMTPSA id p14-20020a7bcc8e000000b003f727764b10sm4849065wma.4.2023.06.10.00.30.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jun 2023 00:30:16 -0700 (PDT) From: Jean Boussier Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] Prefer to use rb_io_descriptor in my_fileno Message-Id: <3DC9CAC8-5708-4001-B4F1-899D46DA9AC1@gmail.com> Date: Sat, 10 Jun 2023 09:30:15 +0200 Cc: raindrops-public@yhbt.net To: samuel.williams@oriontransfer.co.nz X-Mailer: Apple Mail (2.3696.120.41.1.1) List-Id: > the "why" I think the missing piece here is that this change is necessary for = compatibility with the current ruby master: https://bugs.ruby-lang.org/issues/19057#note-17 kgio seem to have the same code and fail in the same way.=