From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7A1961F55F for ; Sat, 23 Sep 2023 09:56:36 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Mq4qyREN; dkim-atps=neutral Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-403012f27e3so37017175e9.3 for ; Sat, 23 Sep 2023 02:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695462993; x=1696067793; darn=yhbt.net; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=/LmoG3FMTVGvQt05SNDt2mNA8Nn4DX/vr4xp0xhx36w=; b=Mq4qyRENDGIDK04gysXcSAQGynJ23eQdxrC2dzyXc3/KDiDOoGOpVKpklAun+is/Ce pfTF8vfpY6oTGYZ372DlEDEeQv7FZQ3Sfz5C87eq4p95CczcRDcLPamh85z0fJtssDDm +15olhEyyOeCyym7WPTJ/5/qiaB3pocR6+HsXGhIJSSttCzudCMEHpoI7OU0kDD1n8G3 VeU+LJ/+dqKe2M0JkvaZ6liCoIRE2yPLciUZXFglYqF5Wjm7dXSwgzia0V92uTsqvNaW +zmUpE5iH7jlx6opQSpCZuqk7S7J1hjG6tbMjviFAWoHObwaM/NgC3o3NccA6HK/yvlL cIlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695462993; x=1696067793; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/LmoG3FMTVGvQt05SNDt2mNA8Nn4DX/vr4xp0xhx36w=; b=OL1dKBOLpLM7PIfv4fbMouSP8O/jRePfkFZ1Q7T4ztMrT6KLLW5VMljxnbkKouRj4u oUuqbKPJbMWvsyFUfRt2L+JFo3T/JEnruo2FnB1HUJvtuW4yVJGl0W4qTBuXB4x9eVX+ 8lP+1QN7aIPIIV9qrjs6yezxTGv4E+8tfTm+lpDN81+V7MojGPGNzQ2OXgXiiBcvJfwQ qIVk1Fy8QAvrWKKb6kV4vWuDkfP3F0DRFi2xdhQqv+0kUnqfNBjmXoGGiGCmDaLh7dEd kUSf4JTFikN73sHX/rEULikJJVAZimu3B0WaPq0awo1eJLXw9xIJqq0SEMqVdYEdAAgu 5YVA== X-Gm-Message-State: AOJu0YzOzUiY67oHMKQeNd4RMqRF8fMYs6Sggd7mQq0kNnZZ4EIjbTNE CHUJ7jPlhQ1ms4UjmiSBvO5W6vTzGCM= X-Google-Smtp-Source: AGHT+IGSzToflMMxJfusI7a9vBR365llo7Vusa2T0u4yS9uGGog9nc5+5uFmH4yqsubwFPGCcOTyzw== X-Received: by 2002:a05:600c:2809:b0:401:38dc:8918 with SMTP id m9-20020a05600c280900b0040138dc8918mr1604235wmb.24.1695462993074; Sat, 23 Sep 2023 02:56:33 -0700 (PDT) Received: from smtpclient.apple ([2a01:e0a:2a1:c1c0:171:d5aa:f5c8:ff83]) by smtp.gmail.com with ESMTPSA id c22-20020a05600c171600b00405442edc69sm2634832wmn.14.2023.09.23.02.56.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Sep 2023 02:56:32 -0700 (PDT) From: Jean Boussier Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: [PATCH] tcp_listener_stats: always eagerly close sockets Message-Id: <6E0E349D-A7CE-4B88-8F89-66438BB775A1@gmail.com> Date: Sat, 23 Sep 2023 11:56:31 +0200 To: raindrops-public@yhbt.net X-Mailer: Apple Mail (2.3696.120.41.1.1) List-Id: Hello, Once again apologies for not submitting the patch in an usable format. = It can be downloaded with curl/wget from = https://github.com/casperisfine/raindrops/commit/1c92b440ad7b11a1708a1d5ed= 75b0767f213b40a.patch I just debugged an issue with our system, I was witnessing the number of file descriptor in our process grow at an alarming rate which I mapped to our use of raindrops to report utilisation. For various reasons we don=E2=80=99t call raindrops from a Rack = middleware but have one process that monitor the socket continuously, and share that data with the workers. Since we call tcp_listener_stats every seconds in a process that doesn't do much else, GC very rarely triggers if at all which cause `InetDiagSocket` instances to accumulate very quickly. Each of those instances holds a file descriptor. Looking at the raindrops implementation it seems to assume the GC will take care of regularly closing these sockets, but I think it=E2=80=99s a bit too bold of an assumption. Regards. --- ext/raindrops/linux_inet_diag.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ext/raindrops/linux_inet_diag.c = b/ext/raindrops/linux_inet_diag.c index 2a2360c..b3d9a51 100644 --- a/ext/raindrops/linux_inet_diag.c +++ b/ext/raindrops/linux_inet_diag.c @@ -634,7 +634,7 @@ static VALUE tcp_listener_stats(int argc, VALUE = *argv, VALUE self) switch (TYPE(addrs)) { case T_STRING: rb_hash_aset(rv, addrs, tcp_stats(&args, addrs)); - return rv; + goto out; case T_ARRAY: { long i; long len =3D RARRAY_LEN(addrs); @@ -643,7 +643,7 @@ static VALUE tcp_listener_stats(int argc, VALUE = *argv, VALUE self) VALUE cur =3D rb_ary_entry(addrs, 0); =20 rb_hash_aset(rv, cur, tcp_stats(&args, cur)); - return rv; + goto out; } for (i =3D 0; i < len; i++) { union any_addr check; @@ -659,6 +659,7 @@ static VALUE tcp_listener_stats(int argc, VALUE = *argv, VALUE self) gen_bytecode_all(&args.iov[2]); break; default: + rb_io_close(sock); rb_raise(rb_eArgError, "addr must be an array of strings, a string, or = nil"); } @@ -671,6 +672,7 @@ static VALUE tcp_listener_stats(int argc, VALUE = *argv, VALUE self) if (RHASH_SIZE(rv) > 1) rb_hash_foreach(rv, drop_placeholders, Qfalse); =20 +out: /* let GC deal with corner cases */ if (argc < 2) rb_io_close(sock); return rv;