From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS63949 194.195.248.0/21 X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from mail.oriontransfer.net (mail.oriontransfer.net [194.195.253.146]) by dcvr.yhbt.net (Postfix) with ESMTP id AC53E1F542 for ; Fri, 9 Jun 2023 10:53:45 +0000 (UTC) Received: from smtpclient.apple (sp49-97-92-87.msc.spmode.ne.jp [49.97.92.87]) by mail.oriontransfer.net (Postfix) with ESMTPSA id AEB2B2B080 for ; Fri, 9 Jun 2023 10:53:44 +0000 (UTC) From: Samuel Williams Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH] Improve compatibility with Ruby 3.3+ Date: Fri, 9 Jun 2023 19:53:31 +0900 References: <20230609104805.39022-1-samuel.williams@oriontransfer.co.nz> To: raindrops-public@yhbt.net In-Reply-To: <20230609104805.39022-1-samuel.williams@oriontransfer.co.nz> Message-Id: X-Mailer: Apple Mail (2.3731.600.7) List-Id: Eric, you will probably want to apply the same patch to kgio, including = both using `rb_io_descriptor(io)` if it=E2=80=99s available, and also I = recommend making the same changes to drop support for older Ruby = versions as in d843802120e7cb01659b93917c29e3ba014216f1. FYI, we will be at least deprecating all of the internals of rb_io_t in = 3.3, and possibly removing it, if the breakage is minimal. Kind regards, Samuel