From: Dale Hamel <dale.hamel@shopify.com>
To: Eric Wong <e@80x24.org>
Cc: raindrops-public@yhbt.net
Subject: Re: [PATCH] Fix queue stats for sockets with SO_REUSEPORT
Date: Fri, 24 Feb 2023 14:42:38 -0500 [thread overview]
Message-ID: <CA+G7BaHaftciDqK4gzE2ANVffB-DMdPaBAwCwCn1cB1i38jGCQ@mail.gmail.com> (raw)
In-Reply-To: <20230224190922.M629699@dcvr>
> I'm honestly shocked that these features get used;
> I never convinced the org I worked for to use them :x
So far we haven't actually found a production use case
for SO_REUSEPORT with Unicorn. We thought we had some
promising early results - but it turned out to be this
instrumentation error in raindrops.
At least by fixing this, efforts in the future will have the correct
metrics to base tests off of.
> Anything else? Could tag a release in a bit...
No, that's it! My apologies for sending as two patches,
I didn't notice the bug in my test until I had already
submitted, naturally.
Thanks very much for the quick review!
next prev parent reply other threads:[~2023-02-24 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:35 [PATCH] Fix queue stats for sockets with SO_REUSEPORT Dale Hamel
2023-02-24 18:47 ` [PATCH] Fix off by one error in test Dale Hamel
2023-02-24 19:09 ` [PATCH] Fix queue stats for sockets with SO_REUSEPORT Eric Wong
2023-02-24 19:42 ` Dale Hamel [this message]
2023-02-25 0:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/raindrops/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+G7BaHaftciDqK4gzE2ANVffB-DMdPaBAwCwCn1cB1i38jGCQ@mail.gmail.com \
--to=dale.hamel@shopify.com \
--cc=e@80x24.org \
--cc=raindrops-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).