From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS47066 71.19.144.0/20
X-Spam-Status: No, score=-1.2 required=3.0 tests=BAYES_00,FREEMAIL_FROM,
 FROM_STARTS_WITH_NUMS,MSGID_FROM_MTA_HEADER shortcircuit=no autolearn=no
 version=3.3.2
Path: news.gmane.org!not-for-mail
From: Hleb Valoshka <375gnu@gmail.com>
Newsgroups: gmane.comp.lang.ruby.raindrops.general
Subject: Re: [PATCH 2/2] Return real stats instead of True
Date: Mon, 9 Sep 2013 22:37:12 +0300
Message-ID:
 <CAAB-KckpMYtQo3yeXAu1Su=Up+_g8vyU23DNPYBojwdtFCEy5A@mail.gmail.com>
References: <1378753439-13495-1-git-send-email-375GNU@Gmail.COM>
 <1378753439-13495-2-git-send-email-375GNU@Gmail.COM>
 <20130909192020.GA18010@dcvr.yhbt.net>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1378755446 14144 80.91.229.3 (9 Sep 2013 19:37:26 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Mon, 9 Sep 2013 19:37:26 +0000 (UTC)
To: raindrops@librelist.org
Original-X-From: raindrops@librelist.org Mon Sep 09 21:37:30 2013
Return-path: <raindrops@librelist.org>
Envelope-to: gclrrg-raindrops@m.gmane.org
List-Archive: <http://librelist.com/archives/raindrops/>
List-Help: <http://librelist.com/help.html>
List-Id: <raindrops-public@bogomips.org>
List-Post: <mailto:raindrops@librelist.org>
List-Subscribe: <mailto:raindrops-subscribe@librelist.com>
List-Unsubscribe: <mailto:raindrops-unsubscribe@librelist.com>
Precedence: list
Original-Sender: raindrops@librelist.org
Xref: news.gmane.org gmane.comp.lang.ruby.raindrops.general:125
Archived-At:
 <http://permalink.gmane.org/gmane.comp.lang.ruby.raindrops.general/125>
Received: from zedshaw2.xen.prgmr.com ([71.19.156.177]) by plane.gmane.org
 with esmtp (Exim 4.69) (envelope-from <raindrops@librelist.org>) id
 1VJ7H3-0006O9-Me for gclrrg-raindrops@m.gmane.org; Mon, 09 Sep 2013 21:37:25
 +0200
Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by
 zedshaw2.xen.prgmr.com (Postfix) with ESMTP id 0E71774E65 for
 <gclrrg-raindrops@m.gmane.org>; Mon,  9 Sep 2013 19:46:49 +0000 (UTC)

On 9/9/13, Eric Wong <normalperson@yhbt.net> wrote:
> This deserves an explanation (and ideally, a test case).  I haven't
> looked at the code in a while and needed to think a bit about
> when the fix is relevant.

You better reject it. I've made it because of test failure:

Error: test_tcp_multi(TestLinuxIPv6)
  NoMethodError: undefined method `queued' for true:TrueClass
test/test_linux_ipv6.rb:54:in `test_tcp_multi'
     51:     addrs = [ addr1, addr2 ]
     52:     stats = tcp_listener_stats(addrs)
     53:     assert_equal 2, stats.size
  => 54:     assert_equal 0, stats[addr1].queued
     55:     assert_equal 0, stats[addr1].active
     56:     assert_equal 0, stats[addr2].queued
     57:     assert_equal 0, stats[addr2].active

With that changes test's passed. (I didn't noticed that time that you
process that Qtrues).

But the real reason may be something else: I've got IPv6 address using
Teredo and getnameinfo returns error with it. So it cause other
errors, I need to check it better.