From a8dfec2568830241a27fce10014b6151a7a47813 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sun, 11 Jun 2023 21:33:25 +0000 Subject: avoid unnecessary #to_io calls Calling `#to_io' is only necessary when we're handling an argument from user code where the user could pass a non-IO object. `#to_io' calls are a waste of time when we create the IO object ourselves (in `Raindrops::InetDiagSock.new'). This allows us to define the `my_fileno' macro for Ruby 3.1+ users to call the new `rb_io_descriptor' function directly without an extra C stack frame. This also allows us to get rid of nesting CPP directives inside C functions which (IMHO) improves readability. Furthermore, any necessary #to_io calls using `rb_convert_type' can be replaced with `rb_io_get_io' to decrease code size. `rb_io_get_io' has been in ruby/io.h since Ruby 1.9.2 and there's no expectation that it'd be deprecated since it only deals with opaque `VALUE' types. --- ext/raindrops/tcp_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ext/raindrops/tcp_info.c') diff --git a/ext/raindrops/tcp_info.c b/ext/raindrops/tcp_info.c index b82f705..c0d34e0 100644 --- a/ext/raindrops/tcp_info.c +++ b/ext/raindrops/tcp_info.c @@ -76,7 +76,7 @@ static VALUE alloc(VALUE klass) */ static VALUE init(VALUE self, VALUE io) { - int fd = my_fileno(io); + int fd = my_fileno(rb_io_get_io(io)); struct tcp_info *info = DATA_PTR(self); socklen_t len = (socklen_t)sizeof(struct tcp_info); int rc = getsockopt(fd, IPPROTO_TCP, TCP_INFO, info, &len); -- cgit v1.2.3-24-ge0c7