io_splice RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: ruby-io-splice@bogomips.org
Subject: [PATCH] pack internal structs for 64-bit systems
Date: Sat, 10 Jan 2015 03:27:16 +0000	[thread overview]
Message-ID: <20150110032716.GA4842@dcvr.yhbt.net> (raw)

This reduces stack usage in some places, perhaps providing a
miniscule improvement in GC performance.

struct          before  after   difference
splice_args	48	40	8
vmsplice_args	32	24	8
---
 ext/io_splice/io_splice_ext.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/io_splice/io_splice_ext.c b/ext/io_splice/io_splice_ext.c
index 2e2caec..276f3a6 100644
--- a/ext/io_splice/io_splice_ext.c
+++ b/ext/io_splice/io_splice_ext.c
@@ -125,8 +125,8 @@ static void * WITHOUT_GVL(rb_blocking_function_t *func, void *data1,
 
 struct splice_args {
 	int fd_in;
-	off_t *off_in;
 	int fd_out;
+	off_t *off_in;
 	off_t *off_out;
 	size_t len;
 	unsigned flags;
@@ -402,9 +402,9 @@ static VALUE trytee(int argc, VALUE *argv, VALUE self)
 
 struct vmsplice_args {
 	int fd;
+	unsigned flags;
 	struct iovec *iov;
 	unsigned long nr_segs;
-	unsigned flags;
 };
 
 static void * nogvl_vmsplice(void *ptr)
-- 
EW

                 reply	other threads:[~2015-01-10  3:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/ruby_io_splice/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150110032716.GA4842@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=ruby-io-splice@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/ruby_io_splice.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).