ruby-tdb user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: ruby-tdb-public@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] test/test_tdb_mt.rb: fix fragile test
Date: Sun, 29 Apr 2018 21:59:07 +0000	[thread overview]
Message-ID: <20180429215907.20076-1-e@80x24.org> (raw)

Method#inspect has changed in modern Ruby, so try to make test
less fragile.
---
 test/test_tdb_mt.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/test_tdb_mt.rb b/test/test_tdb_mt.rb
index 781e2bd..7f8611c 100644
--- a/test/test_tdb_mt.rb
+++ b/test/test_tdb_mt.rb
@@ -90,7 +90,10 @@ class Test_TDB_MT < Test::Unit::TestCase
     @tdb = TDB.new(nil)
     respond_to?(:refute_match) and
       m.each { |meth| refute_match(/\bTDB::MT\b/, @tdb.method(meth).to_s) }
+    before = m.map { |meth| [ meth, @tdb.method(meth).to_s ] }
     @tdb.threadsafe!
-    m.each { |meth| assert_match(/\bTDB::MT\b/, @tdb.method(meth).to_s) }
+    before.each do |(meth, old)|
+      refute_equal old, @tdb.method(meth).to_s
+    end
   end
 end
-- 
EW


                 reply	other threads:[~2018-04-29 21:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/ruby-tdb/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180429215907.20076-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=ruby-tdb-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/ruby-tdb.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).