sleepy_penguin RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: sleepy.penguin@librelist.org
Subject: Re: [sleepy.penguin] [PATCH] epoll: avoid EPOLL_CTL_MOD race condition
Date: Thu, 17 Jan 2013 21:35:59 +0000	[thread overview]
Message-ID: <20130117213559.GA12465@dcvr.yhbt.net> (raw)
In-Reply-To: <20130103041904.GA29931@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> wrote:
> Until everybody updates to a version of the Linux kernel with
> this fix, we need to enable a workaround for older kernels using
> EPOLL_CTL_DEL + EPOLL_CTL_ADD to emulate EPOLL_CTL_MOD behavior.
> 
> This race condition is fixed in Linux upstream
> commit 128dd1759d96ad36c379240f8b9463e8acfd37a1 and included in
> Linux v3.8-rc2 and later.
 
Linux 3.7.3, 3.4.26, 3.2.37, 3.0.59 all have this fix already.
Linux 3.5.7.3 will also have this.

> This fix will likely be backported to stable and vendor kernels,
> so we'll whitelist them as we learn of them.

I've reverted this workaround (and pushed to master @
git://bogomips.org/sleepy_penguin.git )

commit b3fa14976bc41c2daad0b8a6afd74a8212dcb97b
Author: Eric Wong <normalperson@yhbt.net>
Date:   Thu Jan 17 21:30:30 2013 +0000

    Revert "epoll: avoid EPOLL_CTL_MOD race condition"
    
    This reverts commit 02e5a91b24983d96b342c007661966495ccdb619.
    
    This workaround may have unintended side-effects for apps using
    EPOLL_CTL_DEL.
-- 
Eric Wong


      reply	other threads:[~2013-01-17 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-03  4:19 [sleepy.penguin] [PATCH] epoll: avoid EPOLL_CTL_MOD race condition Eric Wong
2013-01-17 21:35 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/sleepy_penguin/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117213559.GA12465@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=sleepy.penguin@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/sleepy_penguin.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).