From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS49160 62.122.208.0/22 X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from junki.org (junki.org [62.122.209.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6303120229 for ; Thu, 20 Oct 2016 20:26:00 +0000 (UTC) Received: by junki.org (Postfix, from userid 1000) id BA86DE094; Thu, 20 Oct 2016 23:25:59 +0300 (MSK) Received: from msd.home (msd.home [10.0.0.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by junki.org (Postfix) with ESMTPSA id 8D27FE08B; Thu, 20 Oct 2016 23:25:57 +0300 (MSK) Message-ID: <1476995156.1736.166.camel@junki.org> Subject: Re: [PATCH] Add some tolerance (RFC2616 sec. 19.3) From: Mishael A Sibiryakov To: Eric Wong Cc: unicorn-public@bogomips.org Date: Thu, 20 Oct 2016 23:25:56 +0300 In-Reply-To: <20161020175554.GA15564@starla> References: <1476954332.1736.156.camel@junki.org> <20161020175554.GA15564@starla> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 List-Id: On Thu, 2016-10-20 at 17:55 +0000, Eric Wong wrote: > Thanks for that useful explanation.  Aside from the unnecessary, > "Hi all,", that is an informative commit message which justifies > the usefulness of that patch. > > > > > Github commit https://github.com/uno4ki/unicorn/commit/ed127b66e162aaf1 > > 76de05720f6be758f8b41b1f > > Unfortunately, the commit message in your git repo is lacking. > I've used the text at the top of your email. It's just a temporary fork and I'm too lazy )) > Eeep, Evolution does some strange things with formatting > whitespaces.  It looks like instructions for making it nicer are > in the Linux kernel: > > https://bogomips.org/mirrors/linux.git/plain/Documentation/email-clients.txt?h=v4.8 Whoops, my fault.  > > +  def test_multiline_header_0d0a > > +    parser = HttpParser.new > > +    parser.buf << "GET / HTTP/1.0\r\nX-Multiline-Header: foo > > bar\r\n\tcha cha\r\n\tzha zha\r\n\r\n" > > I expect code to be wrapped at 80 lines or less.  Fixed locally. > (I need big fonts, even 80 is a compromise, I really prefer 64) Line 221 with "ssl bullshit" guided me to this. > Anyways, pushed to the "rfc2616-sec19.3" branch. > > I've also uploaded a prerelease 5.1.0.4.gd5fbb to RubyGems > for folks without Ragel. > > gem install --pre unicorn -v 5.1.0.4.gd5fbb > > Anything else?  Expect a 5.2.0 release in a few days or so. > Thanks. Thanks for the quick acceptance.