From: Eric Wong <normalperson@yhbt.net>
To: unicorn general mailing list <mongrel-unicorn@rubyforge.org>
Subject: Re: Unicorn Nginx Issue
Date: Tue, 13 Oct 2009 12:43:24 -0700 [thread overview]
Message-ID: <20091013194324.GA1676@dcvr.yhbt.net> (raw)
In-Reply-To: <91d915350910131203w2b67ddbcjba9189c2eac303d2@mail.gmail.com>
Matt Mongeau <halogenandtoast@gmail.com> wrote:
> sudo gem check -t unicorn
Again, please don't top post on this mailing list (nor on other technical
mailing lists in general).
> fails
>
> Failure:
> test_rack_lint_big_put(RequestTest) [./test/unit/test_request.rb:178]:
> <nil> expected but was
> <"
>
> followed by lots whitespace
>
> ">.
Unrelated to the problem we were having, but this really should be
working, especially with 0.93.2 or later. Is anybody else out there
hitting this?
> Error:
> test_expand_addr(TestConfigurator):
> SocketError: getaddrinfo: nodename nor servname provided, or not known
> /opt/local/lib/ruby/gems/1.8/gems/unicorn-0.93.2/lib/unicorn/configurator.rb:346:in
> `pack_sockaddr_in'
> /opt/local/lib/ruby/gems/1.8/gems/unicorn-0.93.2/lib/unicorn/configurator.rb:346:in
> `expand_addr'
> ./test/unit/test_configurator.rb:35:in `call'
> ./test/unit/test_configurator.rb:35:in `test_expand_addr'
This looks like a portability issue. I'll probably rip those tests out
since a good chunk of systems don't addresses like this.
But above this test failure, the other test_expand_addr assertions
manage to pass which is strange, namely the following:
meth = Unicorn::Configurator.new.method(:expand_addr)
assert_equal "/var/run/unicorn.sock", meth.call("/var/run/unicorn.sock")
assert_equal "#{Dir.pwd}/foo/bar.sock", meth.call("unix:foo/bar.sock")
Your original paths were under 104 bytes, too[1]
> >> I had
> >> listen '/Users/mattmongeau/projects/test/unicorn/tmp/sockets/unicorn.sock',
> >> :backlog => 1024
> >> I guess I needed
> >> listen 'unix:/Users/mattmongeau/projects/test/unicorn/tmp/sockets/unicorn.sock',
> >> :backlog => 1024
Does using a shorter path help at all?
Shorter (and shallower) paths are even a small bit faster because the
filesystem has to do less work to resolve it for every connection :)
[1] - http://portabilityblog.com/blog/archives/4-UNIX-domain-sockets.html
--
Eric Wong
next prev parent reply other threads:[~2009-10-13 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 16:57 Unicorn Nginx Issue Matt Mongeau
2009-10-13 17:20 ` Brian Ketelsen
2009-10-13 17:27 ` Matt Mongeau
2009-10-13 17:34 ` Matt Mongeau
2009-10-13 18:53 ` Eric Wong
2009-10-13 19:03 ` Matt Mongeau
2009-10-13 19:43 ` Eric Wong [this message]
2009-10-13 20:11 ` Matt Mongeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013194324.GA1676@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).