From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=-0.2 required=5.0 tests=AWL shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: archivist@yhbt.net Delivered-To: archivist@dcvr.yhbt.net Received: from rubyforge.org (50-56-192-79.static.cloud-ips.com [50.56.192.79]) by dcvr.yhbt.net (Postfix) with ESMTP id 840581F727 for ; Tue, 29 Jan 2013 03:52:56 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 249322E099; Tue, 29 Jan 2013 03:52:56 +0000 (UTC) X-Original-To: mongrel-unicorn@rubyforge.org Delivered-To: mongrel-unicorn@rubyforge.org Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by rubyforge.org (Postfix) with ESMTP id E74D82E084 for ; Tue, 29 Jan 2013 03:52:49 +0000 (UTC) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D193E1F724; Tue, 29 Jan 2013 03:52:48 +0000 (UTC) Date: Tue, 29 Jan 2013 03:52:48 +0000 From: Eric Wong To: unicorn list Subject: Re: [PATCH] Add -N or --no-default-middleware option. Message-ID: <20130129035231.GA27702@dcvr.yhbt.net> References: <1359429679-21255-1-git-send-email-godfat@godfat.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1359429679-21255-1-git-send-email-godfat@godfat.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Lin Jen-Shin X-BeenThere: mongrel-unicorn@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: mongrel-unicorn-bounces@rubyforge.org Errors-To: mongrel-unicorn-bounces@rubyforge.org Lin Jen-Shin wrote: > + opts.on("-N", "--no-default-middleware", > + "no default middleware even if RACK_ENV is development") do |e| RACK_ENV=deployment also loads middleware, so I think it's more accurate with: do not load middleware implied by RACK_ENV This also puts us back within the 80-column limit imposed by "test_help" in test/exec/test_exec.rb Will sign-off and push that change squashed unless there are objections. I also just bumped master to rack 1.5.1, which fixes the Rack::Lint test regression in 1.5.0. Will pull in the "hijack" branch into master soon (and release 4.6.0) since all my questions about it have been answered in rack-devel. _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying