From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: pid file handling issue
Date: Fri, 25 Oct 2013 20:31:55 +0000 [thread overview]
Message-ID: <20131025203155.GA17767@dcvr.yhbt.net> (raw)
In-Reply-To: <CAM3ce8FuR0PO4b0xk526MzVW=AOQqVXOtMkQAvVN2Rrzxx-3nw@mail.gmail.com>
Hongli Lai <hongli@phusion.nl> wrote:
> On Fri, Oct 25, 2013 at 12:58 AM, Eric Wong <normalperson@yhbt.net> wrote:
> > + # rename the old pid if posible
>
> Nitpick: you have a typo here. :)
Thanks, will push :)
Subject: [PATCH] http_server: fixup comments for PID file renaming
Thanks to Hongli Lai for noticing my typo. While we're at it, finish up
a halfway-written comment for the EXDEV case
---
lib/unicorn/http_server.rb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
index a6266ea..2decd77 100644
--- a/lib/unicorn/http_server.rb
+++ b/lib/unicorn/http_server.rb
@@ -221,13 +221,13 @@ class Unicorn::HttpServer
end
end
- # rename the old pid if posible
+ # rename the old pid if possible
if @pid && path
begin
File.rename(@pid, path)
rescue Errno::ENOENT, Errno::EXDEV
- # a user may have accidentally removed the original.
- # Obviously cross-FS renames
+ # a user may have accidentally removed the original,
+ # obviously cross-FS renames don't work, either.
clobber_pid(path)
end
else
--
1.8.4.483.g7fe67e6.dirty
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
prev parent reply other threads:[~2013-10-25 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 22:55 pid file handling issue Michael Fischer
2013-10-24 0:53 ` Eric Wong
2013-10-24 1:01 ` Michael Fischer
2013-10-24 2:03 ` Eric Wong
2013-10-24 17:51 ` Michael Fischer
2013-10-24 18:21 ` Eric Wong
2013-10-24 19:57 ` Michael Fischer
2013-10-24 20:27 ` Eric Wong
2013-10-24 22:58 ` Eric Wong
2013-10-25 7:33 ` Hongli Lai
2013-10-25 20:31 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131025203155.GA17767@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).