From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Cc: Camilo Lopez <camilo@shopify.com>, admin@camilolopez.com
Subject: Re: [PATCH] Kill lazy workers with TERM before KILL
Date: Wed, 16 Apr 2014 08:44:16 +0000 [thread overview]
Message-ID: <20140416084416.GA9709@dcvr.yhbt.net> (raw)
In-Reply-To: <1397619318-28190-2-git-send-email-camilo@shopify.com>
Camilo Lopez <camilo@camilolopez.com> wrote:
> We want to know what was going on with a lazy worker, KILL is un-trappable so we
> are sending TERM instead, then to make sure the process really dies we are
> KILLing a second later.
Sorry, no. I've rejected similar patches in the past. If your process
is capable of responding to SIGTERM, the Ruby VM is still in good shape
and capable of doing timeouts within itself.
Use application timeouts, which work without modifying unicorn
(and work on servers other than unicorn):
http://unicorn.bogomips.org/Application_Timeouts.html
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
prev parent reply other threads:[~2014-04-16 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 3:35 [PATCH] Print stack for lazy workers Camilo Lopez
2014-04-16 3:35 ` [PATCH] Kill lazy workers with TERM before KILL Camilo Lopez
2014-04-16 8:44 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416084416.GA9709@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=admin@camilolopez.com \
--cc=camilo@shopify.com \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).