From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Status: No, score=-2.1 required=3.0 tests=AWL,BAYES_00,URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: unicorn-public@bogomips.org Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1040D1F406 for ; Thu, 21 Jan 2016 22:09:14 +0000 (UTC) Received: by mail-pf0-f176.google.com with SMTP id n128so30137391pfn.3 for ; Thu, 21 Jan 2016 14:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenderlovemaking-com.20150623.gappssmtp.com; s=20150623; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=+vNrx9l+XjYSQoVtdAqUrptHL3UXLh6w7B4QFEozaWw=; b=sQ06O0LwilkGD3sGT9qmcARiZ0jgDbeG9aeXRRT5WV/zNZLdvfs4QG9eeSXVNDwL8r VnSgaHndHDsNVKPxeveaEzeRciowKW210X5OB4UEygjRSl7oldDL/Qnjtojxf3qMexSm U726Pk4IRDCwhtiiofj0yARS2YVug78nRnobDF3rrHfRShe5529kLMXTL9Es9zJb/MAu qRdHoi1XB8NplHUrpTRrjP8xpPp3uBwzOL1Oab7GNZgck/kK7gs15uapQjdOsB2PokYu Ri5BwhLPeHCkn7qTIADxO4sC5xShwkqCiw+eoDxyJbOJPTDaaXcRFsVDG0A4nleSGx4h 7K8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=+vNrx9l+XjYSQoVtdAqUrptHL3UXLh6w7B4QFEozaWw=; b=KBFVwWRioq3WyaRQMHaoQS14ZFl1iCOoI1VetWPtkHRrNb+TOa5O/FLvWEyLcPXpkv h5fcBGynFgeGPquuyxeN6+J5XvwrrLP8oT2NPNMsSxfzcJOzLorWUzSQcdQRPAPpgrZr 7kz0HcbJEl3NZrKLFbkey7sYf+uXmJOpOe22Z+Nn3nGx+RYIV8+84Wg7HO+PEuJjVxS4 mKRgp2nlm02ViFpfvYBOjx5IIKlF7C3a0wCX1OTnv7RUQrnw4nNJMZ57uH4c7Boeor3u eHaABbNgwED0eOstuaDnYs0jgmSikc8NRDAyTGLSi9ckaYFZw86tlrUiiUUysfrAsiHE B26A== X-Gm-Message-State: ALoCoQm6qVTs4GhK8Ub/sVscA2mCjktBmT981PF1c7n7di9Myf6IZKx/5RNl9TISkulchYUgtQVM3SLFJ0jQLq/C2l0OAFENbg== X-Received: by 10.98.86.8 with SMTP id k8mr63014217pfb.28.1453414153401; Thu, 21 Jan 2016 14:09:13 -0800 (PST) Received: from TC.local (c-24-56-229-227.customer.broadstripe.net. [24.56.229.227]) by smtp.gmail.com with ESMTPSA id q89sm4747985pfa.70.2016.01.21.14.09.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2016 14:09:12 -0800 (PST) Sender: Aaron Patterson Date: Thu, 21 Jan 2016 14:09:10 -0800 From: Aaron Patterson To: rack-devel@googlegroups.com Cc: Adam Duke , Aaron Patterson , unicorn-public@bogomips.org Subject: Re: [PATCH] limit rack version for ruby compatibility Message-ID: <20160121220910.GB51960@TC.local> References: <20160108191807.GA30703@dcvr.yhbt.net> <20160108215046.GA36373@TC.local> <20160108223732.GA28771@dcvr.yhbt.net> <20160108231910.GA42107@TC.local> <20160121201255.GA6186@dcvr.yhbt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160121201255.GA6186@dcvr.yhbt.net> User-Agent: Mutt/1.5.23 (2014-03-12) List-Id: On Thu, Jan 21, 2016 at 08:12:55PM +0000, Eric Wong wrote: > Adam Duke wrote: > > Following up on this, it seems to me like keeping the Ruby 2.2.2 > > requirement is the right way to go for rack. If the unicorn project > > wants to continue support for older rubies, the unicorn gemspec should > > be changed to limit the rack dependency to '< 2'. If rack 2.0.0 is > > released and there is no limit on the dependency in unicorn's gemspec, > > it seems to me like any deployments that are not running Ruby 2.2.2 > > will fail. > > I prefer we drop the rack dependency entirely. We don't use rack > for much. This seems doable, (totally untested) patch below: [snip] Ah, that was a much smaller patch than I had anticipated! :D -- Aaron Patterson http://tenderlovemaking.com/