From: Eric Wong <e@80x24.org> To: Jeremy Evans <code@jeremyevans.net> Cc: unicorn-public@bogomips.org Subject: Re: Patch: Add after_worker_exit configuration option Date: Tue, 21 Feb 2017 20:15:26 +0000 Message-ID: <20170221201526.GA7035@starla> (raw) In-Reply-To: <20170221200216.GJ93742@jeremyevans.local> Jeremy Evans <code@jeremyevans.net> wrote: > On 02/21 07:43, Eric Wong wrote: > > Jeremy Evans <code@jeremyevans.net> wrote: > > > This option can be used to implement custom behavior for handling > > > worker exits. For example, let's say you have a specific request > > > that crashes a worker process, which you expect to be due to a > > > improperly programmed C extension. By modifying your worker to > > > save request related data in a temporary file and using this option, > > > you can get a record of what request is crashing the application, > > > which will make debugging easier. > > > > > > This is not a complete patch as it doesn't include tests, but > > > before writing tests I wanted to see if this is something you'd > > > consider including in unicorn. > > > > What advantage does this have over Ruby's builtin at_exit? > > at_exit is not called if the interpreter crashes: > > ruby -e 'at_exit{File.write('a.txt', 'a')}; Process.kill :SEGV, $$' 2>/dev/null > ([ -f a.txt ] && echo at_exit called) || echo at_exit not called Ah, thanks. I didn't read the code carefully, enough. The commit message and documentation should reflect that it's called in the master and not the worker. Anyways, this is probably OK since I can't think of a less intrusive or more generic (across all Rack servers) way of doing it. So I'm inclined to accept some version of this. > --- a/lib/unicorn/http_server.rb > +++ b/lib/unicorn/http_server.rb > @@ -14,7 +14,8 @@ class Unicorn::HttpServer > attr_accessor :app, :timeout, :worker_processes, > :before_fork, :after_fork, :before_exec, > :listener_opts, :preload_app, > - :orig_app, :config, :ready_pipe, :user > + :orig_app, :config, :ready_pipe, :user, > + :after_worker_exit I've been trying to reduce the method entry overhead across the board. Since this is a new field, can it be attr_writer solely for configurator? I don't think there's reader dependency other than below... > @@ -395,8 +396,7 @@ def reap_all_workers > proc_name 'master' > else > worker = @workers.delete(wpid) and worker.close rescue nil > - m = "reaped #{status.inspect} worker=#{worker.nr rescue 'unknown'}" > - status.success? ? logger.info(m) : logger.error(m) > + after_worker_exit.call(self, worker, status) Which can be made to access the ivar directly: @after_worker_exit.call(self, worker, status)
next prev parent reply index Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-21 19:19 Jeremy Evans 2017-02-21 19:43 ` Eric Wong 2017-02-21 20:02 ` Jeremy Evans 2017-02-21 20:15 ` Eric Wong [this message] 2017-02-21 20:49 ` Jeremy Evans 2017-02-21 21:38 ` Eric Wong
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://bogomips.org/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170221201526.GA7035@starla \ --to=e@80x24.org \ --cc=code@jeremyevans.net \ --cc=unicorn-public@bogomips.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help Archives are clonable: git clone --mirror https://bogomips.org/unicorn-public git clone --mirror http://ou63pmih66umazou.onion/unicorn-public Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.lang.ruby.unicorn nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.unicorn note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git