* [PATCH] t0011-active-unix-socket.sh: fix race condition in test
@ 2017-02-28 23:00 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-28 23:00 UTC (permalink / raw)
To: unicorn-public
Killing the master process may lead to the worker dying on its
own (as designed); before kill(1) has had an opportunity to send
the second kill(2) syscall on the worker process.
Killing the worker before the master might also lead to a
needless respawn, so merely kill the master and let the worker
follow it in death.
This race condition occasionally caused test failures on slow,
uniprocessor hardware.
---
t/t0011-active-unix-socket.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0011-active-unix-socket.sh b/t/t0011-active-unix-socket.sh
index d256f5c..fae0b6c 100755
--- a/t/t0011-active-unix-socket.sh
+++ b/t/t0011-active-unix-socket.sh
@@ -52,7 +52,7 @@ t_begin "worker pid unchanged (again)" && {
}
t_begin "nuking the existing Unicorn succeeds" && {
- kill -9 $unicorn_pid $worker_pid
+ kill -9 $unicorn_pid
while kill -0 $unicorn_pid
do
sleep 1
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-28 23:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28 23:00 [PATCH] t0011-active-unix-socket.sh: fix race condition in test Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).