From: Eric Wong <e@80x24.org>
To: Simon Eskildsen <simon.eskildsen@shopify.com>
Cc: unicorn-public@bogomips.org
Subject: Re: [PATCH] check_client_connection: use tcp state on linux
Date: Wed, 1 Mar 2017 03:18:28 +0000 [thread overview]
Message-ID: <20170301031828.GA19430@dcvr> (raw)
In-Reply-To: <20170228211254.GA3868@whir>
> Simon Eskildsen <simon.eskildsen@shopify.com> wrote:
> > + tcp_info = Raindrops::TCP_Info.new(socket)
> > + raise Errno::EPIPE, "client closed connection".freeze, [] if
> > closed_state?(tcp_info.state)
Also, I guess if you're using this frequently, it might make
sense to keep the tcp_info object around and recycle it
using the Raindrops::TCP_Info#get! method.
#get! has always been supported in raindrops, but I just noticed
RDoc wasn't picking it up properly :x
Anyways I've fixed the documentation over on the raindrops list
https://bogomips.org/raindrops-public/20170301025541.26183-1-e@80x24.org/
("[PATCH] ext: fix documentation for C ext-defined classes")
https://bogomips.org/raindrops-public/20170301025546.26233-1-e@80x24.org/
("[PATCH] TCP_Info: custom documentation for #get!")
... and updated the RDoc on https://bogomips.org/raindrops/
Heck, I wonder if it even makes sense to reuse a frozen empty
Array when raising the exception...
next prev parent reply other threads:[~2017-03-01 3:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 14:03 [PATCH] check_client_connection: use tcp state on linux Simon Eskildsen
2017-02-25 16:19 ` Simon Eskildsen
2017-02-25 23:12 ` Eric Wong
2017-02-27 11:44 ` Simon Eskildsen
2017-02-28 21:12 ` Eric Wong
2017-03-01 3:18 ` Eric Wong [this message]
2017-03-06 21:32 ` Simon Eskildsen
2017-03-07 22:50 ` Eric Wong
2017-03-08 0:26 ` Eric Wong
2017-03-08 12:06 ` Simon Eskildsen
2017-03-13 20:16 ` Simon Eskildsen
2017-03-13 20:37 ` Eric Wong
2017-03-14 16:14 ` Simon Eskildsen
2017-03-14 16:41 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301031828.GA19430@dcvr \
--to=e@80x24.org \
--cc=simon.eskildsen@shopify.com \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).