From: Eric Wong <email@example.com> To: Jeremy Evans <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] Add worker_exec configuration option V2 Date: Fri, 10 Mar 2017 21:19:07 +0000 Message-ID: <20170310211907.GA5022@untitled> (raw) In-Reply-To: <20170309194119.GD35527@jeremyevans.local> Jeremy Evans <firstname.lastname@example.org> wrote: > Here's V2 of the patch, which I think should address all of the issues > you pointed out. Thanks. Pushed to git://80x24.org/unicorn worker_exec I can add tests, later, or you can. I also had some FreeBSD test fixes (which might apply to OpenBSD) on a VM somewhere which I'll Cc: you on: there was also just SO_KEEPALIVE fix I posted: https://email@example.com/raw > worker_nr = -1 > until (worker_nr += 1) == @worker_processes > @workers.value?(worker_nr) and next > worker = Unicorn::Worker.new(worker_nr) > before_fork.call(self, worker) > - if pid = fork > - @workers[pid] = worker > - worker.atfork_parent > + > + pid = if @worker_exec > + worker_spawn(worker) > else > - after_fork_internal > - worker_loop(worker) > - exit > + fork do > + after_fork_internal > + worker_loop(worker) > + exit > + end I prefer to avoid the block with fork. The block deepens the stack for the running app, so it can affect GC efficiency. Can be fixed in a separate patch...
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-08 18:44 [PATCH] Add worker_exec configuration option Jeremy Evans 2017-03-08 20:02 ` Eric Wong 2017-03-09 4:52 ` Jeremy Evans 2017-03-09 13:57 ` Eric Wong 2017-03-09 19:41 ` [PATCH] Add worker_exec configuration option V2 Jeremy Evans 2017-03-10 21:19 ` Eric Wong [this message] 2017-03-11 5:26 ` Jeremy Evans 2017-03-11 7:18 ` Eric Wong 2017-03-13 15:32 ` Jeremy Evans 2017-03-13 19:18 ` Eric Wong
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://bogomips.org/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170310211907.GA5022@untitled \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help Archives are clonable: git clone --mirror https://bogomips.org/unicorn-public git clone --mirror http://ou63pmih66umazou.onion/unicorn-public Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.lang.ruby.unicorn nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.unicorn note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox