* [PATCH] freebsd: avoid EINVAL when setting accept filter
@ 2017-03-10 23:01 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-03-10 23:01 UTC (permalink / raw)
To: unicorn-public
Accept filters can only be set on listen sockets, and it also
fails with EINVAL if it's already set.
Untested, but I suppose changing the accept filter on a listening
socket is not supported, either; since that could affect in-flight
sockets.
---
lib/unicorn/socket_helper.rb | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/unicorn/socket_helper.rb b/lib/unicorn/socket_helper.rb
index df8315e..7aa2bb0 100644
--- a/lib/unicorn/socket_helper.rb
+++ b/lib/unicorn/socket_helper.rb
@@ -63,12 +63,15 @@ def set_tcp_sockopt(sock, opt)
elsif respond_to?(:accf_arg)
name = opt[:accept_filter]
name = DEFAULTS[:accept_filter] if name.nil?
+ sock.listen(opt[:backlog])
+ got = (sock.getsockopt(:SOL_SOCKET, :SO_ACCEPTFILTER) rescue nil).to_s
+ arg = accf_arg(name)
begin
- sock.setsockopt(:SOL_SOCKET, :SO_ACCEPTFILTER, accf_arg(name))
+ sock.setsockopt(:SOL_SOCKET, :SO_ACCEPTFILTER, arg)
rescue => e
logger.error("#{sock_name(sock)} " \
"failed to set accept_filter=#{name} (#{e.inspect})")
- end
+ end if arg != got
end
end
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-10 23:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-10 23:01 [PATCH] freebsd: avoid EINVAL when setting accept filter Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).