From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS40173 216.86.168.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mxout-08.mxes.net (mxout-08.mxes.net [216.86.168.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 004652095B; Tue, 21 Mar 2017 18:48:51 +0000 (UTC) Received: from battleground.jeremyevans.local (unknown [73.90.99.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTPSA id 81BF8509BE; Tue, 21 Mar 2017 14:48:48 -0400 (EDT) Received: from jeremyevans.local (speedstar.jeremyevans.local [10.187.8.2]) by battleground.jeremyevans.local (OpenSMTPD) with ESMTP id 5bbe8842; Tue, 21 Mar 2017 11:48:47 -0700 (PDT) Date: Tue, 21 Mar 2017 11:48:47 -0700 From: Jeremy Evans To: Eric Wong Cc: Simon Eskildsen , unicorn-public@bogomips.org, raindrops-public@bogomips.org Subject: Re: [PATCH (ccc)] http_request: support proposed Raindrops::TCP states on Message-ID: <20170321184847.GC38466@jeremyevans.local> References: <20170316031652.17433-1-e@80x24.org> <20170321025554.GA15807@starla> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170321025554.GA15807@starla> User-Agent: Mutt/1.7.2 (2016-11-26) List-Id: On 03/21 02:55, Eric Wong wrote: > TCP states names/numbers seem stable for each OS, but differ in > name and numeric values between them. So I started upon this > patch series for raindrops last week: > > https://bogomips.org/raindrops-public/20170316031652.17433-1-e@80x24.org/T/ > > And things seem to be alright, for the most part. Anyways > here's a proposed patch for unicorn which takes advantage of > the above (proposed) changes for raindrops and will allow > unicorn to support check_client_connection > > Also Cc:-ing Jeremy to see if he has any input on the OpenBSD > side of things. OpenBSD seems to support the constants you are using in raindrops: #define TCPS_CLOSED 0 /* closed */ #define TCPS_LISTEN 1 /* listening for connection */ #define TCPS_SYN_SENT 2 /* active, have sent syn */ #define TCPS_SYN_RECEIVED 3 /* have sent and received syn */ #define TCPS_ESTABLISHED 4 /* established */ #define TCPS_CLOSE_WAIT 5 /* rcvd fin, waiting for close */ #define TCPS_FIN_WAIT_1 6 /* have closed, sent fin */ #define TCPS_CLOSING 7 /* closed xchd FIN; await ACK */ #define TCPS_LAST_ACK 8 /* had fin and close; await FIN ACK */ #define TCPS_FIN_WAIT_2 9 /* have closed, fin is acked */ #define TCPS_TIME_WAIT 10 /* in 2*msl quiet wait after close */ I'm fine with dropping raindrops as a unicorn dependency and making it optional if it isn't necessary for correct operation. Thanks, Jeremy