From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS40173 216.86.168.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mxout-07.mxes.net (mxout-07.mxes.net [216.86.168.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0ED7020834 for ; Mon, 17 Jul 2017 14:32:57 +0000 (UTC) Received: from battleground.jeremyevans.local (unknown [73.90.99.19]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTPSA id AF57B22E259; Mon, 17 Jul 2017 10:32:54 -0400 (EDT) Received: from jeremyevans.local (speedstar.jeremyevans.local [10.187.8.2]) by battleground.jeremyevans.local (OpenSMTPD) with ESMTP id 721becda; Mon, 17 Jul 2017 07:32:53 -0700 (PDT) Date: Mon, 17 Jul 2017 07:32:53 -0700 From: Jeremy Evans To: Eric Wong Cc: Pere Joan Martorell , unicorn-public@bogomips.org, Philip Cunningham , Jonathan del Strother Subject: Re: Random crash when sending USR2 + QUIT signals to Unicorn process Message-ID: <20170717143253.GA55601@jeremyevans.local> References: <20170713193409.GA24162@starla> <20170714211608.GA3272@starla> <20170714225015.GD68067@jeremyevans.local> <20170715001535.GA8205@starla> <20170715013411.GE68067@jeremyevans.local> <20170715044523.GA19602@starla> <20170715075631.GF68067@jeremyevans.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170715075631.GF68067@jeremyevans.local> User-Agent: Mutt/1.8.3 (2017-05-23) List-Id: On 07/15 12:56, Jeremy Evans wrote: > On 07/15 04:45, Eric Wong wrote: > > Jeremy Evans wrote: > > > All of Sequel's postgres adapter tests still pass with this, so I merged > > > this into the master branch. I'll do some more testing of my apps, but > > > unless I run into problems I plan to release this as sequel_pg 1.7.1 > > > early next week. > > > > Thanks for the update. Btw, did you get a chance to test with > > GC.stress? It's not 100% reliable (and it is slow), but > > probably could've caught problems like this one. > > I hadn't tested with GC.stress before. You weren't kidding about it being > slow. I'll let it run overnight with the previous code (without your > patch), to see if this is something it would have caught. Running with GC.stress didn't catch the error for me. But I'm using a fairly old compiler (GCC 4.2.1, the OpenBSD default), so this may be something that only shows up on a newer compiler that does more optimizations. Thanks, Jeremy