unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Sam Saffron <sam.saffron@gmail.com>
Cc: unicorn-public@bogomips.org
Subject: Re: Log URL with murder_lazy_workers
Date: Mon, 15 Jan 2018 01:57:40 +0000	[thread overview]
Message-ID: <20180115015740.GA850@dcvr> (raw)
In-Reply-To: <CAAtdryM9pRQwE+hkSgMckRxhCXTxKOAxn+3ejZkZwaGaNk7vWg@mail.gmail.com>

Sam Saffron <sam.saffron@gmail.com> wrote:
> I would love to start logging the actual URL that timed out when
> murder_lazy_workers does its thing.
> 
> Clearly the master process has no knowledge here, but perhaps if we
> had a named pipe from each child to master we could quickly post
> current url down the pipe so we would have something to log when we
> murder a url.

That would make the master a bottleneck.

Instead, I suggest logging a START action with the
URL+PID+Thread(*)+serial number; and then matching it a
corresponding END action in the response_body#close Anything
without a corresponding END action can be deemed a loss and
matched up with the KILL action based on PID.

(*) Log Thread/Fiber so it can work with other servers, too.


I seem to remember it was possible to get that information out of
Rails logs pretty easily, already; and I seem recall doing that
back many years ago when I used Rails. (This is probably why
USR1 log reopening waits until a response is done before
triggering...)


And as I've stated many times before, I don't want any sort of
lock-in or even guide-in to make people feel like they're stuck
using unicorn (by having code which depends on it).  I also
believe the unicorn `timeout' is a misfeature that probably set
the entire Rack/Ruby ecosystem back 10 years or more, so I'd
rather people stop depending on it and fix their timeouts.

(To that end, I may see about making timeout.rb in stdlib better
 for Ruby 2.6...)

> Clearly an opt-in thing, but would be very handy for quick diagnostics
> cause we can then avoid deeper log analysis and raise events just as
> this happens.

Sorry, I prefer generic solutions which work with other servers, too.

  reply	other threads:[~2018-01-15  1:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 23:27 Log URL with murder_lazy_workers Sam Saffron
2018-01-15  1:57 ` Eric Wong [this message]
2018-01-15  2:18   ` Sam Saffron
     [not found]     ` <CADGZSScpXo7-PvM=Ki64hhPSzWAsjyT+fWKAZ9-30U69x+54iA@mail.gmail.com>
2018-01-15  3:22       ` Sam Saffron
2018-01-15 15:06 ` Carl Brasic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115015740.GA850@dcvr \
    --to=e@80x24.org \
    --cc=sam.saffron@gmail.com \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).