From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 5C38D1F803;
	Thu, 10 Jan 2019 20:28:21 +0000 (UTC)
Date: Thu, 10 Jan 2019 20:28:21 +0000
From: Eric Wong <e@80x24.org>
To: Dominik George <natureshadow@debian.org>, 918916@bugs.debian.org
Cc: Justin Hallett <thesin@southofheaven.org>, unicorn-public@bogomips.org
Subject: Re: Bug#918916: Unicorn not reporting proper version for gemfile?
Message-ID: <20190110202821.3gmzl27l4p4n2na3@dcvr>
References: <E5E85D7F-061C-422C-B02E-8FC248F87986@southofheaven.org>
 <E5E85D7F-061C-422C-B02E-8FC248F87986@southofheaven.org>
 <20190110200102.GA14520@portux.naturalnet.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190110200102.GA14520@portux.naturalnet.de>
List-Id: <unicorn-public.bogomips.org>

(unicorn upstream here, adding unicorn-public to Cc,
 for context: <https://bugs.debian.org/918916> )

Dominik George <natureshadow@debian.org> wrote:
> +--- a/unicorn.gemspec
> ++++ b/unicorn.gemspec
> +@@ -11,7 +11,7 @@ end.compact
> + 
> + Gem::Specification.new do |s|
> +   s.name = %q{unicorn}
> +-  s.version = (ENV['VERSION'] || '5.4.1').dup
> ++  s.version = '5.4.1'

Why is ignoring ENV['VERSION'] necessary for the Debian build?
I can probably remove that check if desired from the upstream
package before the 5.5.0 release.