unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Peter Giacomo Lombardo <peter.lombardo@instana.com>
To: unicorn-public@bogomips.org
Subject: Storing Multiple Blocks for Configurator Hooks
Date: Mon, 28 Nov 2016 17:26:39 +0100	[thread overview]
Message-ID: <5B3FDDDF-5910-4672-84CA-ED07A7CEC8C6@instana.com> (raw)

Please excuse if this has been discussed or already decided upon - searches came up with nothing.

Has unicorn considered allowing multiple blocks to be supplied for Configurator Hooks (e.g. after_fork et. al.)?

Currently, it seems that only one block can be specified:
https://bogomips.org/unicorn.git/tree/lib/unicorn/configurator.rb#n628

If instead this were stored as an array of blocks, gems could register their own blocks to be run when the hooks are called which would result in less end-user burden and easier on-ramping to get a running system.  

(Confronting the ActiveRecord establish_connection and Redis re-connect seem to be a rite of passage into using Unicorn)

Has this already been discussed/decided upon?

Best,
Peter

—
Peter Giacomo Lombardo
Ruby Instrumentation Lead
https://github.com/pglombardo

Instana, Inc
https://www.instana.com

             reply	other threads:[~2016-11-28 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 16:26 Peter Giacomo Lombardo [this message]
2016-11-28 17:57 ` Storing Multiple Blocks for Configurator Hooks Eric Wong
2016-11-29 21:29   ` Peter Giacomo Lombardo
2016-11-30  4:26     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B3FDDDF-5910-4672-84CA-ED07A7CEC8C6@instana.com \
    --to=peter.lombardo@instana.com \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).