* Re: pid file handling issue
@ 2013-10-25 20:31 7% ` Eric Wong
0 siblings, 0 replies; 1+ results
From: Eric Wong @ 2013-10-25 20:31 UTC (permalink / raw)
To: unicorn list
Hongli Lai <hongli@phusion.nl> wrote:
> On Fri, Oct 25, 2013 at 12:58 AM, Eric Wong <normalperson@yhbt.net> wrote:
> > + # rename the old pid if posible
>
> Nitpick: you have a typo here. :)
Thanks, will push :)
Subject: [PATCH] http_server: fixup comments for PID file renaming
Thanks to Hongli Lai for noticing my typo. While we're at it, finish up
a halfway-written comment for the EXDEV case
---
lib/unicorn/http_server.rb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
index a6266ea..2decd77 100644
--- a/lib/unicorn/http_server.rb
+++ b/lib/unicorn/http_server.rb
@@ -221,13 +221,13 @@ class Unicorn::HttpServer
end
end
- # rename the old pid if posible
+ # rename the old pid if possible
if @pid && path
begin
File.rename(@pid, path)
rescue Errno::ENOENT, Errno::EXDEV
- # a user may have accidentally removed the original.
- # Obviously cross-FS renames
+ # a user may have accidentally removed the original,
+ # obviously cross-FS renames don't work, either.
clobber_pid(path)
end
else
--
1.8.4.483.g7fe67e6.dirty
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply related [relevance 7%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2013-10-23 22:55 pid file handling issue Michael Fischer
2013-10-24 0:53 ` Eric Wong
2013-10-24 1:01 ` Michael Fischer
2013-10-24 2:03 ` Eric Wong
2013-10-24 17:51 ` Michael Fischer
2013-10-24 18:21 ` Eric Wong
2013-10-24 19:57 ` Michael Fischer
2013-10-24 22:58 ` Eric Wong
2013-10-25 7:33 ` Hongli Lai
2013-10-25 20:31 7% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).