* Re: [ANN] unicorn 4.8.0.pre1 prerelease gem
2013-12-09 9:54 5% [ANN] unicorn 4.8.0.pre1 prerelease gem Eric Wong
@ 2014-01-09 21:50 0% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2014-01-09 21:50 UTC (permalink / raw)
To: mongrel-unicorn
Eric Wong <normalperson@yhbt.net> wrote:
> tests: fix SO_REUSEPORT tests for old Linux and non-Linux
> stream_input: avoid IO#close on client disconnect
> t0300: kill off stray processes in test
> always write PID file early for compatibility
> doc: clarify SIGNALS and reference init example
> rework master-to-worker signaling to use a pipe
Btw, has anybody tried this? I haven't noticed any issues, and I'm
thinking about releasing this as 4.8.0 as-is (with some minor doc
updates)
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply [relevance 0%]
* [ANN] unicorn 4.8.0.pre1 prerelease gem
@ 2013-12-09 9:54 5% Eric Wong
2014-01-09 21:50 0% ` Eric Wong
0 siblings, 1 reply; 3+ results
From: Eric Wong @ 2013-12-09 9:54 UTC (permalink / raw)
To: mongrel-unicorn
Changes since 4.7.0:
Eric Wong (6):
tests: fix SO_REUSEPORT tests for old Linux and non-Linux
stream_input: avoid IO#close on client disconnect
t0300: kill off stray processes in test
always write PID file early for compatibility
doc: clarify SIGNALS and reference init example
rework master-to-worker signaling to use a pipe
gem install --pre unicorn
git://bogomips.org/unicorn
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply [relevance 5%]
* [PATCH] stream_input: avoid IO#close on client disconnect
@ 2013-11-07 20:22 14% ` Eric Wong
0 siblings, 0 replies; 3+ results
From: Eric Wong @ 2013-11-07 20:22 UTC (permalink / raw)
To: Andrew Hobson; +Cc: mongrel-unicorn
Eric Wong <normalperson@yhbt.net> wrote:
> Andrew Hobson <ahobson@gmail.com> wrote:
> > I applied that one line patch a day and a half ago and we haven't seen
> > the error in the field (yet). I am optimistic you have elegantly fixed
> > the problem.
> >
> > If we do see an error, I will send another email to the list.
> >
> > Thanks again for your help,
>
> No problem, I'll push that out later today.
Pushed, thanks again:
>From f4005d5efc608e7d75371f0d0527041facd33f89 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Thu, 7 Nov 2013 20:10:01 +0000
Subject: [PATCH] stream_input: avoid IO#close on client disconnect
This can avoid IOError from being seen by the application, and also
reduces points where IO#close may be called. This is a good thing
if we eventually port this code into a low-level server like
cmogstored where per-client memory space is defined by FD number of
a client.
Reported-by: Andrew Hobson <ahobson@gmail.com>
---
lib/unicorn/stream_input.rb | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/unicorn/stream_input.rb b/lib/unicorn/stream_input.rb
index c8a4240..9278f47 100644
--- a/lib/unicorn/stream_input.rb
+++ b/lib/unicorn/stream_input.rb
@@ -139,10 +139,7 @@ private
# we do support clients that shutdown(SHUT_WR) after the
# _entire_ request has been sent, and those will not have
# raised EOFError on us.
- if @socket
- @socket.shutdown
- @socket.close
- end
+ @socket.shutdown if @socket
ensure
raise Unicorn::ClientShutdown, "bytes_read=#{@bytes_read}", []
end
--
1.8.4.483.g7fe67e6.dirty
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
^ permalink raw reply related [relevance 14%]
Results 1-3 of 3 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2013-11-05 14:46 Handling closed clients Andrew Hobson
2013-11-05 17:20 ` Eric Wong
[not found] ` <m2iow6k7nk.fsf@macdaddy.atl.damballa>
2013-11-05 20:51 ` Eric Wong
[not found] ` <m21u2sjpc9.fsf@macdaddy.atl.damballa>
2013-11-07 16:48 ` Eric Wong
2013-11-07 20:22 14% ` [PATCH] stream_input: avoid IO#close on client disconnect Eric Wong
2013-12-09 9:54 5% [ANN] unicorn 4.8.0.pre1 prerelease gem Eric Wong
2014-01-09 21:50 0% ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).