From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=-0.1 required=5.0 tests=AWL,T_DKIM_INVALID shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: archivist@yhbt.net Delivered-To: archivist@dcvr.yhbt.net Received: from rubyforge.org (50-56-192-79.static.cloud-ips.com [50.56.192.79]) by dcvr.yhbt.net (Postfix) with ESMTP id 892701F727 for ; Tue, 29 Jan 2013 04:04:55 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 5E0D82E099; Tue, 29 Jan 2013 04:04:55 +0000 (UTC) X-Original-To: mongrel-unicorn@rubyforge.org Delivered-To: mongrel-unicorn@rubyforge.org Received: from mail-ea0-f172.google.com (mail-ea0-f172.google.com [209.85.215.172]) by rubyforge.org (Postfix) with ESMTP id E50072E084 for ; Tue, 29 Jan 2013 04:04:30 +0000 (UTC) Received: by mail-ea0-f172.google.com with SMTP id f13so1472eaa.31 for ; Mon, 28 Jan 2013 20:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=godfat.org; s=google; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=hzXJ8M5c/eesPzv1ODbIszOXGYvThQDtD7AghDS31fI=; b=IGG3TR5EOE8BbqNP9jOFnXaAtcBGTLCP0LxXsWndBJRbeKyAK9FVALv4XBeCh+r3qv RBLfc0nbqezCJAMr6qJgkj5iwOe6vSccWKTahkLUCfYbC/45+eAc6Au9QgpcebG0gNNu ADAmQ1KQMaglmOkwn06YljabaNEgmd23bUzwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:x-gm-message-state; bh=hzXJ8M5c/eesPzv1ODbIszOXGYvThQDtD7AghDS31fI=; b=NPLfsADHvou6UfKfEYPEXUa/TYaPwD2A5osnYuk9seh5EjsNE94OgM1r0LM03bO0KO 3YpWwFniCvtkGmLUfiYzkUj9dWqxQA3U1Jzs7xSeDmoYTVNX3ku41iOJa9Lr6QE3yuY+ Tp2k9NoJL9q3qXJB3WC8ii0eOTsDiheMNFth+70fWM+TMaj9HCnZKRFRyn74MZoNkh9V d8cex76jzT8r96oC740Hb28XERIT5QXXYWmWJcqaBExn2pA78vwQSxhKxWXyqwyOwPm4 jQjd6MASYeI2hZ3FCwmIeHqn2WsHiokBVYhUUonTBOW8KA/w9cbQyMkoNUGXKcNkUxa6 s9AA== X-Received: by 10.14.223.137 with SMTP id v9mr420087eep.22.1359432269575; Mon, 28 Jan 2013 20:04:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.74.208 with HTTP; Mon, 28 Jan 2013 20:03:59 -0800 (PST) In-Reply-To: <20130129035231.GA27702@dcvr.yhbt.net> References: <1359429679-21255-1-git-send-email-godfat@godfat.org> <20130129035231.GA27702@dcvr.yhbt.net> From: "Lin Jen-Shin (godfat)" Date: Tue, 29 Jan 2013 12:03:59 +0800 Message-ID: Subject: Re: [PATCH] Add -N or --no-default-middleware option. To: Eric Wong X-Gm-Message-State: ALoCoQlN8J3th4AO7Yv55sRkBI5tv5YmA9oJg9wtb+2M1m135YBogmjgDqZUsqMcnYp0Vbad4avC Cc: unicorn list X-BeenThere: mongrel-unicorn@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: mongrel-unicorn-bounces@rubyforge.org Errors-To: mongrel-unicorn-bounces@rubyforge.org On Tue, Jan 29, 2013 at 11:52 AM, Eric Wong wrote: > Lin Jen-Shin wrote: >> + opts.on("-N", "--no-default-middleware", >> + "no default middleware even if RACK_ENV is development") do |e| > > RACK_ENV=deployment also loads middleware, so I think it's more accurate > with: > > do not load middleware implied by RACK_ENV > > This also puts us back within the 80-column limit imposed by "test_help" > in test/exec/test_exec.rb Oh right, I only remembered to keep the source within 80-column limit, but forgot that the output might be longer than source. Thanks for the better wordings. I updated the patch for Zbatery, but it's too late for Rainbows though. > Will sign-off and push that change squashed unless there are objections. Surely, thanks! > I also just bumped master to rack 1.5.1, which fixes the Rack::Lint > test regression in 1.5.0. > > Will pull in the "hijack" branch into master soon (and release 4.6.0) > since all my questions about it have been answered in rack-devel. I haven't had a chance to read hijack more, looking forward to it :) _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying