From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <375gnu@gmail.com>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS3215 2.6.0.0/16
X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
	FROM_STARTS_WITH_NUMS,RCVD_IN_DNSWL_NONE,SPF_PASS shortcircuit=no
	autolearn=no autolearn_force=no version=3.4.2
Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id A9B46211B4
	for <unicorn-public@bogomips.org>; Sat, 12 Jan 2019 09:42:16 +0000 (UTC)
Received: by mail-vs1-xe29.google.com with SMTP id x1so10784772vsc.10
        for <unicorn-public@bogomips.org>; Sat, 12 Jan 2019 01:42:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=C7NzOXMMicfZ3l3L12wvidST4BtK+iyzOb2aAthBpFA=;
        b=Xz3yoeGhDpFxnARySZm9hCz+W+A6A4kouzgfxbrqy8RDQi45hFpxGuOyxS6mcyY0hs
         Y0qKKiEhzD6G+VPmi9SLGYCywPoVdBTxPJ1Xc83l/cEApEXva95b+6SGNqoDGUqHTDa2
         Xthh2/T6xnmmMoNcy+cmOw5hVGh1lsoOnMOG9SSTDuM7MmWaJObYVj8YCn1dMCIkYHAG
         aGJdk4MNz2WUsZpbH3FeVnWd1o1eR9XAHUAcOqegY04OCPhsdN3YpIUJBmxD3faxH5gE
         GysgFT1asePd/WrC/CKJKAeD7vERnvrUfhfFsMhPncS2F6elI3B/tPbK3myrw7DWYiNe
         c7+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=C7NzOXMMicfZ3l3L12wvidST4BtK+iyzOb2aAthBpFA=;
        b=HsM6j+ZDHPmztCo5cIIvu4FQ5/i+9N7QUGqoL7vg1Z2RVIm+OO6kjPXbhv6UCnX7hM
         FLNxV8rhahJbGXsYIYS7VKft0q2KJrmgpHi8G3UkFYbdGscvtmlacDnyGEgFpz++hhf4
         hoOraiOLJ9TLrxS9R9nU5RaQf6zkuwI5JvNC7CpkLy80acqwLvK9xaseovqrv1Rj3R0o
         hqaoaUhwyuHTTwjnXzkKy1Bs8wLMZAOVjeKULI2aypHspW+OMpNzqawboy0hOLRaX+V9
         Bo2ghL7yHflJc++OnNYqy+Vij23QVpdiaN/qIb8NZrgfCGa+OwLa60qaY2mJWZL3LncM
         E5AQ==
X-Gm-Message-State: AJcUukdDRSSbfqvXg7csrlaGneWfIUC1KLuKfHYJlkpRgxyoovIpiFqU
	ef8xlLmv77Z+u9JMgUGxQXF+lS5URpEm10WlNH4=
X-Google-Smtp-Source: ALg8bN73OCsimB9H3xem1znwHKK346ll6sqkrX9tHeEghmolO0g6hNtnolCU4QvUFWPb3pH8sAnX3Fu+1V5ZLuWbOzg=
X-Received: by 2002:a67:b245:: with SMTP id s5mr7247573vsh.200.1547286135178;
 Sat, 12 Jan 2019 01:42:15 -0800 (PST)
MIME-Version: 1.0
Received: by 2002:a9f:28a5:0:0:0:0:0 with HTTP; Sat, 12 Jan 2019 01:42:14
 -0800 (PST)
In-Reply-To: <20190110202821.3gmzl27l4p4n2na3@dcvr>
References: <E5E85D7F-061C-422C-B02E-8FC248F87986@southofheaven.org>
 <20190110200102.GA14520@portux.naturalnet.de> <20190110202821.3gmzl27l4p4n2na3@dcvr>
From: Hleb Valoshka <375gnu@gmail.com>
Date: Sat, 12 Jan 2019 12:42:14 +0300
Message-ID: <CAAB-KcnLdiKLQDtPqbgwiM2gk2qsHXr6m_fuFwD-MijB514Etw@mail.gmail.com>
Subject: Re: Bug#918916: Unicorn not reporting proper version for gemfile?
To: 918916@bugs.debian.org
Cc: Dominik George <natureshadow@debian.org>, Justin Hallett <thesin@southofheaven.org>, 
	unicorn-public@bogomips.org
Content-Type: text/plain; charset="UTF-8"
List-Id: <unicorn-public.bogomips.org>

On 1/10/19, Eric Wong <e@80x24.org> wrote:
>> +-  s.version = (ENV['VERSION'] || '5.4.1').dup
>> ++  s.version = '5.4.1'
>
> Why is ignoring ENV['VERSION'] necessary for the Debian build?
> I can probably remove that check if desired from the upstream
> package before the 5.5.0 release.

I've checked debian's git, this patch was introduced when
ENV["VERSION"] was required to use the gemspec. Now as the upstream
gemspec provides the same it's not required.

The problem is not in Unicorn. The problem is in gem2deb which
generated incorrect unicorn-0.gemspec for the package.