unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: "Ernest W. Durbin III" <ewdurbin@gmail.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: [PATCH] construct listener_fds Hash in 1.8 compatible way
Date: Wed, 29 Jan 2014 17:54:13 -0500	[thread overview]
Message-ID: <CAD1Aak3Vrpgip5nqihX=WkPqX9FtcU92gXae4NXR43pbxTOXYw@mail.gmail.com> (raw)
In-Reply-To: <20140129225250.10947.71973@sandbox56423.mailgun.org>

Apologies for the spam, I had a wacked out command line tool go
haywire on a message that got stuck in spool months ago.

On Fri, Nov 1, 2013 at 10:12 AM, Ernest W. Durbin III
<ewdurbin@gmail.com> wrote:
> This renables the ability for Ruby 1.8 environments to perform reexecs
> ---
>  lib/unicorn/http_server.rb | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
> index 2decd77..9a5795c 100644
> --- a/lib/unicorn/http_server.rb
> +++ b/lib/unicorn/http_server.rb
> @@ -449,13 +449,14 @@ class Unicorn::HttpServer
>      end
>
>      self.reexec_pid = fork do
> -      listener_fds = Hash[LISTENERS.map do |sock|
> +      listener_fds = Hash.new
> +      LISTENERS.map do |sock|
>          # IO#close_on_exec= will be available on any future version of
>          # Ruby that sets FD_CLOEXEC by default on new file descriptors
>          # ref: http://redmine.ruby-lang.org/issues/5041
>          sock.close_on_exec = false if sock.respond_to?(:close_on_exec=)
> -        [ sock.fileno, sock ]
> -      end]
> +        listener_fds[sock.fileno] = sock
> +      end
>        ENV['UNICORN_FD'] = listener_fds.keys.join(',')
>        Dir.chdir(START_CTX[:cwd])
>        cmd = [ START_CTX[0] ].concat(START_CTX[:argv])
> --
> 1.8.4
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

       reply	other threads:[~2014-01-29 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140129225250.10947.71973@sandbox56423.mailgun.org>
2014-01-29 22:54 ` Ernest W. Durbin III [this message]
2013-11-01 14:12 [PATCH] construct listener_fds Hash in 1.8 compatible way Ernest W. Durbin III
2013-11-01 16:50 ` Eric Wong
2013-11-01 17:04   ` Ernest W. Durbin III
2013-11-01 18:54     ` Eric Wong
2013-11-01 19:00       ` Ernest W. Durbin III
2013-11-01 17:46 ` Hleb Valoshka
2013-11-01 18:32   ` Ernest W. Durbin III
2013-11-01 18:49     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD1Aak3Vrpgip5nqihX=WkPqX9FtcU92gXae4NXR43pbxTOXYw@mail.gmail.com' \
    --to=ewdurbin@gmail.com \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).