unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / Atom feed
From: Fumiaki Matsushima <mtsm.fm@gmail.com>
To: unicorn-public@bogomips.org
Cc: Eric Wong <e@80x24.org>, Fumiaki Matsushima <mtsmfm@gmail.com>
Subject: Re: [PATCH] Send SIGTERM before SIGKILL on timeout
Date: Tue, 27 Feb 2018 13:03:47 +0900
Message-ID: <CAF3FHTS-SVQxyp46BH8FgnTauA=Nxf9a0mHHy85Snsmkn4dHPQ@mail.gmail.com> (raw)
In-Reply-To: <20180224151559.GA15504@whir>

Thank you for your reply!

> Right, it's been rejected several times before:

Sorry, I missed these emails.

> I don't want to encourage lazy app development or Rack apps
written with only unicorn in mind

That's true.
I'll use rack-timeout to solve my timeout problem.

Thanks.

On Sun, Feb 25, 2018 at 12:15 AM, Eric Wong <e@80x24.org> wrote:
> Fumiaki MATSUSHIMA <mtsm.fm@gmail.com> wrote:
>> To output log / send error to error tracking service,
>> we need to receive a signal other than SIGKILL first.
>> ---
>> Hi Unicorn team,
>>
>> I'm not sure this change is accetable though,
>> I can find some articles and patches to prevent SIGKILL
>> on timeout.
>
> Right, it's been rejected several times before:
>
>  https://bogomips.org/unicorn-public/20140416084416.GA9709@dcvr.yhbt.net/t/#u
>  https://bogomips.org/unicorn-public/20180115015740.GA850@dcvr/t/#u
>
>> I think it's great if this feature is supported by unicorn itself.
>>
>> Could you give me your opinion?
>
> Again, I don't want to encourage lazy app development or Rack apps
> written with only unicorn in mind.
>
> Existing `timeout' feature of unicorn is already something I hate
> and don't want to encourage further reliance on:
>
>         https://bogomips.org/unicorn/Application_Timeouts.html
>
> Fwiw, I (with ruby-core) will try to make Timeout in ruby stdlib
> have less overhead for 2.6 (or 2.7) so it can benefit more users
> than just unicorn.  Ditto with various OobGC hacks over the years.
>
> Thanks.

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24  8:48 Fumiaki MATSUSHIMA
2018-02-24 15:15 ` Eric Wong
2018-02-27  4:03   ` Fumiaki Matsushima [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://bogomips.org/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF3FHTS-SVQxyp46BH8FgnTauA=Nxf9a0mHHy85Snsmkn4dHPQ@mail.gmail.com' \
    --to=mtsm.fm@gmail.com \
    --cc=e@80x24.org \
    --cc=mtsmfm@gmail.com \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help

Archives are clonable:
	git clone --mirror https://bogomips.org/unicorn-public
	git clone --mirror http://ou63pmih66umazou.onion/unicorn-public

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.lang.ruby.unicorn
	nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.unicorn

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox