From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jcmorrow@thoughtbot.com>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from mail-qt0-f172.google.com (mail-qt0-f172.google.com [209.85.216.172])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by dcvr.yhbt.net (Postfix) with ESMTPS id 5645F20492
	for <unicorn-public@bogomips.org>; Fri,  9 Dec 2016 17:01:28 +0000 (UTC)
Received: by mail-qt0-f172.google.com with SMTP id p16so21512913qta.0
        for <unicorn-public@bogomips.org>; Fri, 09 Dec 2016 09:01:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=thoughtbot-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=gX5y25TRGd/TN6recTLmESE2nwqY3qVAAaxs2SiWiDs=;
        b=rHXE7XVqAVJU3Wt3RxtdhE1smVVB/mnk4c1S3K0+FIWPtTaUBLLcv3m2zlp03aDiID
         YlQlgq4MsGfmTJLLsL1ol9F/jzkLFeMUoHreMuX20EuLlXychJmeYNgXZlPG5nvohL3p
         TVgvR2wVgVRrgZLqGIJPdTJHz/i1VWo1nLwoLgTSMRNdyYIvBPb+69Llqj2Kk9SkWf+L
         7wJXE4hZ8CslstRAowOu1BMVQredjyRR9PCh5k0Vi4U6ktrshTmFMKxfNu010ib1oqPg
         3xVe0ONFIT/uqHlOtWijhXKeQ78Iasskjzv/jofT7Gxzih1IH2geIgsi9NQlVH4zc2bP
         c64w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=gX5y25TRGd/TN6recTLmESE2nwqY3qVAAaxs2SiWiDs=;
        b=jgPSH6uQvMu7hJ5ijg/c8SeQPSUAQJJxzkGTTvJzHHNvd6BRppChgxzwstdUo8TvcO
         0br3xOhb2F2pMVRQQMCKd0J+yAx0ZWB+ViPi101Yhc+gnOM+uhkfPHSlL0pflzXLhJuP
         NDzpKIjVF2cuifkC3u4U3Cj7ThDwXwcQ7cjPdYliRszDfuRKFFCJ/94srv7s5xrV+uHg
         lK9eLAWsGtuHz2dDGo4oVfCOcQwug0n65c2S2jQmSkMAzDwJ3sAsNniSefGIoFt6nwhP
         LmBBi4EAJvjCkrBpb3ywcDbsKdgLVRrAp5KTI/8ryk7A615H2iJsQ9fZOZajvJ30IUy4
         lu1Q==
X-Gm-Message-State: AKaTC017bIZQcYXVOo300bF06plp1yUKgaG5w2Iw4ADPOOlJti8xezRMKXHTf5FURA4gozo6T5C0hoe4ItU8W0Dr
X-Received: by 10.200.37.52 with SMTP id 49mr68176514qtm.240.1481302887398;
 Fri, 09 Dec 2016 09:01:27 -0800 (PST)
MIME-Version: 1.0
Received: by 10.12.173.104 with HTTP; Fri, 9 Dec 2016 09:01:27 -0800 (PST)
In-Reply-To: <20161209015536.GA28543@starla>
References: <CAHdu2E5BX_fzNqrHxekOcfUYr4bLRWP90nC92eSRu_3HPToV8Q@mail.gmail.com>
 <20161208184054.GA5417@starla> <CAHdu2E6=qv1gmLGbZfrivhX5vVYgMq7cwOpCZ9yvFGTR17Prfw@mail.gmail.com>
 <20161209015536.GA28543@starla>
From: Josh Morrow <jcmorrow@thoughtbot.com>
Date: Fri, 9 Dec 2016 09:01:27 -0800
Message-ID: <CAHdu2E6t+XDUEPc4pQePZCZHxbnPpqyko+6=wq6yf+8iYz=7oQ@mail.gmail.com>
Subject: Re: SIGWINCH with Forego/Heroku Local
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@bogomips.org
Content-Type: text/plain; charset=UTF-8
List-Id: <unicorn-public@bogomips.org>

> (please don't drop the public list/archive address from the Cc:)

Whoops, sorry, my bad.

On Thu, Dec 8, 2016 at 5:55 PM, Eric Wong <e@80x24.org> wrote:
> (please don't drop the public list/archive address from the Cc:)
>
> Josh Morrow <jcmorrow@thoughtbot.com> wrote:
>> Eric Wong <e@80x24.org> wrote:
>> > Fwiw, we switched to checking stdin last year so SIGWINCH could
>> > be usable with foreman and other process managers:
>>
>> In foreman `$stdin.tty?` returns `true`. In ForeGO it returns `nil` : (.
>
> `nil` or `false`?  With how unicorn uses it, it doesn't matter,
> but it should really be `false` there based on reading the
> rb_io_isatty function in io.c of the MRI source.
>
> But anyways, I suspect ForeGO redirects the stdin to /dev/null
> (you can check with lsof); which is totally reasonable for
> running daemons.
>
> That is why I recommended the before_fork workaround to
> trap(:WINCH, "DEFAULT") to restore the default noop behavior.